You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/27 02:16:51 UTC

[GitHub] john-bodley commented on a change in pull request #4488: utf8 fixes to csv -> hive upload

john-bodley commented on a change in pull request #4488: utf8 fixes to csv -> hive upload
URL: https://github.com/apache/incubator-superset/pull/4488#discussion_r170797947
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -868,16 +868,17 @@ def get_column_names(filepath):
             secure_filename(form.csv_file.data.filename)
         column_names = get_column_names(upload_path)
         schema_definition = ', '.join(
-            [s + ' STRING ' for s in column_names])
+            [s.decode('utf-8') + ' STRING ' for s in column_names])
 
 Review comment:
   Why do we need to use `decode` here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services