You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:50:58 UTC

[GitHub] [flink] guoweiM opened a new pull request #13898: [FLINK-19936] Make SinkITCase stable

guoweiM opened a new pull request #13898:
URL: https://github.com/apache/flink/pull/13898

<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*

## Contribution Checklist

- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).

- Each pull request should address only one issue, not mix up code from multiple issues.

- Each commit in the pull request has a meaningful commit message (including the JIRA id)

- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

## What is the purpose of the change

In the streaming execution mode there are two uncertain things:

1. The order of receiving the checkpoint complete.(`Committer` receive first or `GlobalCommitter` receive first)
1. Whether the operator can receive the last checkpoint
This patch does following two things to resolve `SinkITCase`'s unstable owning to these two uncertainty

This pr does two things
1. Changing how to verifying the output of `GlobalCommitter` for the case 1
2. Let the `FiniteTestSource` exit only when the Committer/GlobalCommitter received all the elements.

## Brief change log

- *This patch changes how to verifying the output of `GlobalCommitter` to resolve `SinkITCase`'s unstable owning to this uncertainty.*
- *FiniteTestSource exits only after user provide condition is satisfied or time out.*
- *All streaming mode ITCases exit only when the Committer/GlobalCommitter receive all the data or time out*

## Verifying this change

## Does this pull request potentially affect one of the following parts:

- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)

## Documentation

- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-720943479


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8847",
       "triggerID" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71633ca8f8e3312d33fefa31c78d20104d8b92e8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "71633ca8f8e3312d33fefa31c78d20104d8b92e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9e477b74fbb25773f849068790a7a2c111599fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8847) 
   * 71633ca8f8e3312d33fefa31c78d20104d8b92e8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] guoweiM edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

guoweiM edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-721442906

> From the solution, it seems that you think that the source of the instability is that the notification for the completion of the checkpoint does not come before the test exits, right?

Yes. In the streaming execution mode the `Committer/globalCommitter` depends on the checkpoint complete so I let the `FiniteTestSource` waits until the `Committer/GlobalCommitter` receive all the datas.
(Of course if we finish the 《FLIP-147: Support Checkpoints After Tasks Finished》 there will be no this problem.)

Another thing that makes the test unstable is the uncertain order in which the `Committer` and `GlobalCommitter` receives the checkpoint complete notification. It leads that we could not know the output of `GlobalCommitter`("1+3" or "1+2+3" or "1"?) when a checkpoint is complete. So This pr also change how to verify the output of `GlobalCommitter`.
Following is an example that `GlobalCommitter` receive the checkpoint complete before the no.3 `Committer`.

![image](https://user-images.githubusercontent.com/26054913/98054342-a436e500-1e75-11eb-9f72-a829dbe4f260.png)

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] guoweiM commented on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

guoweiM commented on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-721442906

> From the solution, it seems that you think that the source of the instability is that the notification for the completion of the checkpoint does not come before the test exits, right?

Yes. In the streaming execution mode the committer/globalCommitter depends on the checkpoint complete so I let the source waits until the Committer/GlobalCommitter receive all the datas.
(Of course if we finish the 《FLIP-147: Support Checkpoints After Tasks Finished》 there will be no this problem.)

Another thing that makes the test unstable is that the order in which the `Committer` and `GlobalCommitter` receives the checkpoint complete notification. It leads that we could not know the output of `GlobalCommitter` when a checkpoint is complete. So This pr also change how to verify the output of `GlobalCommitter`.
This is an example that `GlobalCommitter` receive the checkpoint complete before the no.3 `Committer`.

![image](https://user-images.githubusercontent.com/26054913/98054342-a436e500-1e75-11eb-9f72-a829dbe4f260.png)

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-720933578






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] guoweiM edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

guoweiM edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-721442906

> From the solution, it seems that you think that the source of the instability is that the notification for the completion of the checkpoint does not come before the test exits, right?

Another thing that makes the test unstable is the uncertain order in which the `Committer` and `GlobalCommitter` receives the checkpoint complete notification. It leads that we could not know the output of `GlobalCommitter`("1+3" or "1+2+3" or "1"?) when a checkpoint is complete. So this pr also changes how to verify the output of `GlobalCommitter`. In the new verification way we verify the splitted output of the GlobalCommitter.

Following is an example that `GlobalCommitter` receive the checkpoint complete before the no.3 `Committer`.

![image](https://user-images.githubusercontent.com/26054913/98054342-a436e500-1e75-11eb-9f72-a829dbe4f260.png)

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] guoweiM edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

guoweiM edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-721442906

> From the solution, it seems that you think that the source of the instability is that the notification for the completion of the checkpoint does not come before the test exits, right?

Another thing that makes the test unstable is the uncertain order in which the `Committer` and `GlobalCommitter` receives the checkpoint complete notification. It leads that we could not know the output of `GlobalCommitter`("1+3" or "1+2+3" or "1"?) when a checkpoint is complete. So this pr also changes how to verify the output of `GlobalCommitter`. In the new verification way we verify the split of the output of the `GlobalCommitter`.

Following is an example that `GlobalCommitter` receive the checkpoint complete before the no.3 `Committer`.

![image](https://user-images.githubusercontent.com/26054913/98054342-a436e500-1e75-11eb-9f72-a829dbe4f260.png)

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-720943479


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8847",
       "triggerID" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9e477b74fbb25773f849068790a7a2c111599fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8847) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-720943479


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8847",
       "triggerID" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71633ca8f8e3312d33fefa31c78d20104d8b92e8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8928",
       "triggerID" : "71633ca8f8e3312d33fefa31c78d20104d8b92e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e9e477b74fbb25773f849068790a7a2c111599fb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8847) 
   * 71633ca8f8e3312d33fefa31c78d20104d8b92e8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8928) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-720943479


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8847",
       "triggerID" : "e9e477b74fbb25773f849068790a7a2c111599fb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "71633ca8f8e3312d33fefa31c78d20104d8b92e8",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8928",
       "triggerID" : "71633ca8f8e3312d33fefa31c78d20104d8b92e8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 71633ca8f8e3312d33fefa31c78d20104d8b92e8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8928) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] kl0u commented on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

kl0u commented on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-721076149






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] kl0u closed pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

kl0u closed pull request #13898:
URL: https://github.com/apache/flink/pull/13898


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] guoweiM edited a comment on pull request #13898: [FLINK-19936] Make SinkITCase stable

Posted by GitBox <gi...@apache.org>.

guoweiM edited a comment on pull request #13898:
URL: https://github.com/apache/flink/pull/13898#issuecomment-721442906

> From the solution, it seems that you think that the source of the instability is that the notification for the completion of the checkpoint does not come before the test exits, right?

Another thing that makes the test unstable is that the order in which the `Committer` and `GlobalCommitter` receives the checkpoint complete notification. It leads that we could not know the output of `GlobalCommitter`("1+3" or "1+2+3" or "1"?) when a checkpoint is complete. So This pr also change how to verify the output of `GlobalCommitter`.
Following is an example that `GlobalCommitter` receive the checkpoint complete before the no.3 `Committer`.

![image](https://user-images.githubusercontent.com/26054913/98054342-a436e500-1e75-11eb-9f72-a829dbe4f260.png)

For queries about this service, please contact Infrastructure at:
users@infra.apache.org