You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/11/02 07:01:30 UTC

[GitHub] [echarts] plainheart opened a new pull request, #17861: fix(data): change deprecated `map.data.hasOwnProperty` to `map.hasKey`

plainheart opened a new pull request, #17861:
URL: https://github.com/apache/echarts/pull/17861

   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   ecomfe/zrender#966 has refactored the HashMap, which prefers the native built-in `Map`. It causes the `HashMap.data.hasOwnProperty` to be not working. So this PR is to change it to `map.hasKey`.
   
   ### Fixed issues
   
   Fix failed unit test `test/ut/spec/data/createDimensions.test.ts`
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   ## Misc
   
   ### ZRender Changes
   
   - [x] This PR depends on ZRender changes (ecomfe/zrender#971).
   
   ### Related test cases or examples to use the new APIs
   
   Please refer to `test/ut/spec/data/createDimensions.test.ts`
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17861: fix(data): change deprecated `map.data.hasOwnProperty` to `map.hasKey`

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17861:
URL: https://github.com/apache/echarts/pull/17861#issuecomment-1304704019

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17861: fix(data): change deprecated `map.data.hasOwnProperty` to `map.hasKey`

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17861:
URL: https://github.com/apache/echarts/pull/17861#issuecomment-1299670793

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.
   
   This PR depends on [ZRender](https://github.com/ecomfe/zrender) changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time).
   You can use `npm i zrender@npm:zrender-nightly@dev` to update package.json.
   If you have any question about this, please leave a comment and we will give you extra help on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #17861: fix(data): change deprecated `map.data.hasOwnProperty` to `map.hasKey`

Posted by GitBox <gi...@apache.org>.
pissang merged PR #17861:
URL: https://github.com/apache/echarts/pull/17861


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org