You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jk...@apache.org on 2007/10/18 23:47:14 UTC
svn commit: r586151 - in /tapestry/tapestry4/trunk: tapestry-annotations/
tapestry-contrib/ tapestry-contrib/src/java/org/apache/tapestry/contrib/ajax/
tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/
tapestry-examples/TimeTracker/ tapest...
Author: jkuhnert
Date: Thu Oct 18 14:47:13 2007
New Revision: 586151
URL: http://svn.apache.org/viewvc?rev=586151&view=rev
Log:
Fixes TAPESTRY-1837. Since @EventListener targets widget functions by default, trying to bind to "onchange" events wouldn't work with GTimePicker. Added functionality so that the GTimePicker widget connects the onchange event of the wrapped text field to the widget onChange function.
Also did misc javascript style cleanup / weird old tapestry version references in some of the pom files.
Modified:
tapestry/tapestry4/trunk/tapestry-annotations/pom.xml
tapestry/tapestry4/trunk/tapestry-contrib/pom.xml
tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/ajax/AjaxStatus.script
tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/PaletteFunctions.js
tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/pom.xml
tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/src/java/org/apache/tapestry/timetracker/page/TaskEntryPage.java
tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js
tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/TimePicker.js
tapestry/tapestry4/trunk/tapestry-portlet/pom.xml
Modified: tapestry/tapestry4/trunk/tapestry-annotations/pom.xml
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-annotations/pom.xml?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-annotations/pom.xml (original)
+++ tapestry/tapestry4/trunk/tapestry-annotations/pom.xml Thu Oct 18 14:47:13 2007
@@ -18,7 +18,7 @@
<dependency>
<groupId>org.apache.tapestry</groupId>
<artifactId>tapestry-framework</artifactId>
- <version>4.1.3</version>
+ <version>4.1.4-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>hivemind</groupId>
Modified: tapestry/tapestry4/trunk/tapestry-contrib/pom.xml
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-contrib/pom.xml?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-contrib/pom.xml (original)
+++ tapestry/tapestry4/trunk/tapestry-contrib/pom.xml Thu Oct 18 14:47:13 2007
@@ -19,7 +19,7 @@
<dependency>
<groupId>org.apache.tapestry</groupId>
<artifactId>tapestry-framework</artifactId>
- <version>4.1.3</version>
+ <version>4.1.4-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>jboss</groupId>
Modified: tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/ajax/AjaxStatus.script
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/ajax/AjaxStatus.script?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/ajax/AjaxStatus.script (original)
+++ tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/ajax/AjaxStatus.script Thu Oct 18 14:47:13 2007
@@ -11,6 +11,6 @@
</unique>
</body>
<initialization>
-if(tapestry.fx) tapestry.fx.attachAjaxStatus("${id}");
+if(tapestry.fx) { tapestry.fx.attachAjaxStatus("${id}"); }
</initialization>
</script>
Modified: tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/PaletteFunctions.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/PaletteFunctions.js?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/PaletteFunctions.js (original)
+++ tapestry/tapestry4/trunk/tapestry-contrib/src/java/org/apache/tapestry/contrib/palette/PaletteFunctions.js Thu Oct 18 14:47:13 2007
@@ -124,14 +124,15 @@
i--;
}
}
- // refresh display in IE - otherwise, option may display empty for a while!
- if (tapestry.isIE) {
- for (var i=0; i < sourceOptions.length; i++){
- source.selectedIndex = i;
- }
- source.selectedIndex = oldSourceIndex;
- source.selectedIndex = -1;
- }
+
+ // refresh display in IE - otherwise, option may display empty for a while!
+ if (tapestry.isIE) {
+ for (var i=0; i < sourceOptions.length; i++){
+ source.selectedIndex = i;
+ }
+ source.selectedIndex = oldSourceIndex;
+ source.selectedIndex = -1;
+ }
},
swapOptions:function(options, selectedIndex, targetIndex){
Modified: tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/pom.xml
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/pom.xml?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/pom.xml (original)
+++ tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/pom.xml Thu Oct 18 14:47:13 2007
@@ -18,17 +18,14 @@
<dependency>
<groupId>org.apache.tapestry</groupId>
<artifactId>tapestry-framework</artifactId>
- <version>4.1.4-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.tapestry</groupId>
<artifactId>tapestry-annotations</artifactId>
- <version>4.1.4-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.tapestry</groupId>
<artifactId>tapestry-contrib</artifactId>
- <version>4.1.4-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>hivemind</groupId>
Modified: tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/src/java/org/apache/tapestry/timetracker/page/TaskEntryPage.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/src/java/org/apache/tapestry/timetracker/page/TaskEntryPage.java?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/src/java/org/apache/tapestry/timetracker/page/TaskEntryPage.java (original)
+++ tapestry/tapestry4/trunk/tapestry-examples/TimeTracker/src/java/org/apache/tapestry/timetracker/page/TaskEntryPage.java Thu Oct 18 14:47:13 2007
@@ -30,9 +30,7 @@
/**
- * Manages entering tasks.
- *
- * @author jkuhnert
+ * Manages entering tasks. Basic demonstration of some of the Tapestry 4.x ajax features.
*/
public abstract class TaskEntryPage<E extends Persistent> extends BasePage
{
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/core.js Thu Oct 18 14:47:13 2007
@@ -761,11 +761,11 @@
props["beventtarget.id"]=node.getAttribute("id");
}
},
-
- /**
- * Function: stopEvent
- */
- stopEvent:dojo.event.browser.stopEvent
+
+ /**
+ * Function: stopEvent
+ */
+ stopEvent:dojo.event.browser.stopEvent
}
tapestry.lang = {
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/TimePicker.js
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/TimePicker.js?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/TimePicker.js (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/js/tapestry/widget/TimePicker.js Thu Oct 18 14:47:13 2007
@@ -85,6 +85,7 @@
dojo.event.connect(this.inputNode, "onblur", this, "onInputBlur");
dojo.event.connect(this.inputNode, "onkeyup", this, "onInputKeyUp");
dojo.event.connect(this.inputNode, "onkeydown", this, "onInputKeyDown");
+ dojo.event.connect(this.inputNode, "onchange", this, "onChange");
dojo.event.connect(this.dropdownNode, "onmouseover", this, "onDropdownMouseOver");
dojo.event.connect(this.dropdownNode, "onmouseout", this, "onDropdownMouseOut");
@@ -312,5 +313,4 @@
this._clearOptionSelection(this.hoveredNode);
this._selectOption(nextNode);
}
-}
-);
+});
Modified: tapestry/tapestry4/trunk/tapestry-portlet/pom.xml
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-portlet/pom.xml?rev=586151&r1=586150&r2=586151&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-portlet/pom.xml (original)
+++ tapestry/tapestry4/trunk/tapestry-portlet/pom.xml Thu Oct 18 14:47:13 2007
@@ -17,7 +17,7 @@
<dependency>
<groupId>org.apache.tapestry</groupId>
<artifactId>tapestry-framework</artifactId>
- <version>4.1.3</version>
+ <version>4.1.4-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>hivemind</groupId>