You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/04/28 03:30:00 UTC
[jira] [Commented] (YARN-11482) Fix bug of DRF comparision DominantResourceFairnessComparator2 in fair scheduler
[ https://issues.apache.org/jira/browse/YARN-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717445#comment-17717445 ]
ASF GitHub Bot commented on YARN-11482:
---------------------------------------
Hexiaoqiao opened a new pull request, #5607:
URL: https://github.com/apache/hadoop/pull/5607
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
DominantResourceFairnessComparator2 was using wrong resource info to get if one queue is needy or not now. We should fix it.
```
boolean s1Needy = resourceInfo1[dominant1].getValue() <
minShareInfo1[dominant1].getValue();
boolean s2Needy = resourceInfo1[dominant2].getValue() <
minShareInfo2[dominant2].getValue();
```
### How was this patch tested?
### For code changes:
- [Y] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
> Fix bug of DRF comparision DominantResourceFairnessComparator2 in fair scheduler
> --------------------------------------------------------------------------------
>
> Key: YARN-11482
> URL: https://issues.apache.org/jira/browse/YARN-11482
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler
> Reporter: Xiaoqiao He
> Assignee: Xiaoqiao He
> Priority: Major
>
> DominantResourceFairnessComparator2 was using wrong resource info to get if one queue is needy or not now. We should fix it.
> {code:java}
> boolean s1Needy = resourceInfo1[dominant1].getValue() <
> minShareInfo1[dominant1].getValue();
> boolean s2Needy = resourceInfo1[dominant2].getValue() <
> minShareInfo2[dominant2].getValue();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org