You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/04/18 23:50:33 UTC
[kudu-CR] tablet service: init serializer with valid schema
Hello Grant Henke, Hao Hao, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15754
to review the following change.
Change subject: tablet_service: init serializer with valid schema
......................................................................
tablet_service: init serializer with valid schema
Seems like the mergings of 163cd256ae and c7c4d47 were out of sync with
each other, leading to a logical conflict that resulted in new scanners
initializing with explicitly disallowed null projections.
Change-Id: Ic0355db2b7b39b99df6aded876ad22f6d2fbd776
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/15754/1
--
To view, visit http://gerrit.cloudera.org:8080/15754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0355db2b7b39b99df6aded876ad22f6d2fbd776
Gerrit-Change-Number: 15754
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet service: init serializer with valid schema
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15754 )
Change subject: tablet_service: init serializer with valid schema
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0355db2b7b39b99df6aded876ad22f6d2fbd776
Gerrit-Change-Number: 15754
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 19 Apr 2020 06:05:06 +0000
Gerrit-HasComments: No
[kudu-CR] tablet service: init serializer with valid schema
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15754 )
Change subject: tablet_service: init serializer with valid schema
......................................................................
tablet_service: init serializer with valid schema
Seems like the mergings of 163cd256ae and c7c4d47 were out of sync with
each other, leading to a logical conflict that resulted in new scanners
initializing with explicitly disallowed null projections.
Change-Id: Ic0355db2b7b39b99df6aded876ad22f6d2fbd776
Reviewed-on: http://gerrit.cloudera.org:8080/15754
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0355db2b7b39b99df6aded876ad22f6d2fbd776
Gerrit-Change-Number: 15754
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet service: init serializer with valid schema
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15754 )
Change subject: tablet_service: init serializer with valid schema
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0355db2b7b39b99df6aded876ad22f6d2fbd776
Gerrit-Change-Number: 15754
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 19 Apr 2020 06:19:52 +0000
Gerrit-HasComments: No
[kudu-CR] tablet service: init serializer with valid schema
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15754 )
Change subject: tablet_service: init serializer with valid schema
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15754
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0355db2b7b39b99df6aded876ad22f6d2fbd776
Gerrit-Change-Number: 15754
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 19 Apr 2020 13:10:36 +0000
Gerrit-HasComments: No