You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by interma <gi...@git.apache.org> on 2017/03/27 09:26:55 UTC
[GitHub] incubator-hawq pull request #1194: Hawq 1396. Fix the bug when query hcatalo...
GitHub user interma opened a pull request:
https://github.com/apache/incubator-hawq/pull/1194
Hawq 1396. Fix the bug when query hcatalog via PXF, add test
add hcatalog test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/interma/interma-hawq hawq-1396
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1194
----
commit 055e5219abdd934db5da9904bc0024858abff14b
Author: interma <in...@outlook.com>
Date: 2017-03-27T05:44:18Z
add hcatalog test case
commit 1731879d4781a44e08b0aadb2c5466c980763458
Author: interma <in...@outlook.com>
Date: 2017-03-27T09:24:46Z
fix bug and add ans-files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1194: Hawq 1396. Fix the bug when query hcatalo...
Posted by interma <gi...@git.apache.org>.
Github user interma closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1194: Hawq 1396. Fix the bug when query hcatalog via P...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1194
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1194: Hawq 1396. Fix the bug when query hcatalog via P...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1194
@linwen @ictmalili @wcl14 @stanlyxiang help to review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1194: Hawq 1396. Fix the bug when query hcatalo...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1194#discussion_r108130047
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -314,6 +314,35 @@ TEST_F(TestHawqRanger, ResourceIncludeATest) {
}
}
+TEST_F(TestHawqRanger, HcatalogTest) {
+ SQLUtility util;
+ if (util.getGUCValue("hawq_acl_type") == "ranger")
+ {
+ /*
+ * create a table in hive and populate some rows
+ */
+ clearEnv(&util, "pxf", 1);
--- End diff --
should clean env for 2 and 3, added from line:340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1194: Hawq 1396. Fix the bug when query hcatalog via P...
Posted by interma <gi...@git.apache.org>.
Github user interma commented on the issue:
https://github.com/apache/incubator-hawq/pull/1194
All fixed.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1194: Hawq 1396. Fix the bug when query hcatalog via P...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the issue:
https://github.com/apache/incubator-hawq/pull/1194
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1194: Hawq 1396. Fix the bug when query hcatalo...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1194#discussion_r108129930
--- Diff: src/test/feature/Ranger/test_ranger.cpp ---
@@ -314,6 +314,35 @@ TEST_F(TestHawqRanger, ResourceIncludeATest) {
}
}
+TEST_F(TestHawqRanger, HcatalogTest) {
+ SQLUtility util;
+ if (util.getGUCValue("hawq_acl_type") == "ranger")
+ {
+ /*
+ * create a table in hive and populate some rows
+ */
+ clearEnv(&util, "pxf", 1);
+ string rootPath(util.getTestRootPath());
+ string sqlPath = rootPath + "/Ranger/data/testhive.sql";
+ auto cmd = hawq::test::stringFormat("hive -f %s", sqlPath.c_str());
+ Command::getCommandStatus(cmd);
+
+ /*
+ * create a user and query this table, fail.
+ */
+ addUser(&util, "pxf", 1, false);
+ runSQLFile(&util, "pxf", "fail", 1);
+
+ /*
+ * add an allow policy for this user and query again, succeed.
--- End diff --
This line of comment is not accurate. Should be "allow policies"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---