[GitHub] [iceberg] samredai commented on pull request #4436: Python: Updates to literals

[GitBox <gi...@apache.org>]

samredai commented on pull request #4436:
URL: https://github.com/apache/iceberg/pull/4436#issuecomment-1084497768


   LGTM!
   
   The lint failure is because mypy is confused by the `isinstance(...)` in the constructor for `Literal`. Once it sees isinstance it sets the type as a general `object`. I think the best thing to do is to add a mypy ignore comment to the value property for `Literal`:
   ```py
       @property
       def value(self) -> T:
           return self._value  # type: ignore
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org