You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "lwz9103 (via GitHub)" <gi...@apache.org> on 2024/06/13 03:51:31 UTC
[PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
lwz9103 opened a new pull request, #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069
## What changes were proposed in this pull request?
(Fixes: \#6053)
## How was this patch tested?
unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "zzcclp (via GitHub)" <gi...@apache.org>.
zzcclp commented on code in PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#discussion_r1639276976
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala:
##########
@@ -43,6 +43,7 @@ import java.util.{ArrayList => JArrayList, HashMap => JHashMap, Map => JMap}
import scala.collection.JavaConverters._
import scala.collection.mutable.ArrayBuffer
+import scala.language.reflectiveCalls
Review Comment:
remove ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#issuecomment-2172755354
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#issuecomment-2164311031
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "lwz9103 (via GitHub)" <gi...@apache.org>.
lwz9103 commented on PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#issuecomment-2164863099
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "baibaichen (via GitHub)" <gi...@apache.org>.
baibaichen commented on code in PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#discussion_r1641177848
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala:
##########
@@ -43,6 +43,7 @@ import java.util.{ArrayList => JArrayList, HashMap => JHashMap, Map => JMap}
import scala.collection.JavaConverters._
import scala.collection.mutable.ArrayBuffer
+import scala.language.reflectiveCalls
Review Comment:
`genFirstStageIterator` 里的 `val iter = new Iterator[Any]` 和 `genFinalStageIterator` 里的 `val resIter = new Iterator[ColumnarBatch]` 基本重复，主要区别就是是否 `updateInputMetrics(inputMetrics)`，如果这里新建一个 `CollectMetricItertor`，一方面可以去除重复代码，另一方面应该可以不用 `import scala.language.reflectiveCalls`，下图是我改了变量名之后的 diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "lwz9103 (via GitHub)" <gi...@apache.org>.
lwz9103 commented on code in PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#discussion_r1639491383
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala:
##########
@@ -43,6 +43,7 @@ import java.util.{ArrayList => JArrayList, HashMap => JHashMap, Map => JMap}
import scala.collection.JavaConverters._
import scala.collection.mutable.ArrayBuffer
+import scala.language.reflectiveCalls
Review Comment:
remove this will cause compile error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "baibaichen (via GitHub)" <gi...@apache.org>.
baibaichen merged PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6053][CH] Move collect native metrics from last hasNext to close and cancel [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#issuecomment-2164310801
https://github.com/apache/incubator-gluten/issues/6053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org