You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Robert Burke (Jira)" <ji...@apache.org> on 2019/08/20 21:20:00 UTC

[jira] [Created] (BEAM-8017) Plumb errors and remove panics from package graphx

Robert Burke created BEAM-8017:
----------------------------------

             Summary: Plumb errors and remove panics from package graphx
                 Key: BEAM-8017
                 URL: https://issues.apache.org/jira/browse/BEAM-8017
             Project: Beam
          Issue Type: Improvement
          Components: sdk-go
            Reporter: Robert Burke


The graphx package, and in particular serialize.go and coder.go should be returning errors back up, rather than panicing when issues occur deeper when marshalling types. It makes errors harder to follow since there's now a less necessary panic trace to skip, rather than a clearly constructed error message.

Not difficult, but may be tedious. Requires plumbing the errors and handling/wrapping them appropriately instead of using panic. Most error handling is presently correctly wrapped anyway.

The graphx package as a rule is intended for beam internal use, and not part of the user surface, so making the API changes (which aren't backwards compatible) isn't the worst. Most of the affected methods are unexported.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)