You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/06 14:07:22 UTC

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #1517: sched/wdog: Change the default value of MAX_WDOGPARMS from 4 to 2

patacongo edited a comment on pull request #1517:
URL: https://github.com/apache/incubator-nuttx/pull/1517#issuecomment-669947676


   I understand why you remove all occurrences of `CONFIG_MAX_WDOGPARMS=1` when the default changed to 2, but whcy do you remove CONFIG_MAX_WDOGPARMS=1?  Those are tiny configurations that might depend on the smaller value.
   
   Technically, when the default changes to 2, all defconfig files that do use the default value should have the setting CONFIG_MAX_WDOGPARMS=4 in order to avoid changing the configurations.  Failure to do this has caused explosive growth with some previous changes to the default that were not handled correctly.  However, in this case, I don't think that there is any real issue because I don't think that more than one ( or maybe two) parameters are ever passed.  But I could be wrong.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org