You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "upthewaterspout (GitHub)" <gi...@apache.org> on 2020/01/07 23:04:37 UTC

[GitHub] [geode] upthewaterspout opened pull request #4572: GEODE-7658: Removing hostname resolution from TcpSocketCreatorAdapter

We didn't need these methods on TcpSocketCreatorAdapter.
* resolveDns is based on whether network partition detection is enabled, which
we can access directly in membership.

* getHostName uses a static hostname cache that we don't need to use
for membership when creating the local address.

* getLocalHost has moved to a utility in geode-common.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #4572: GEODE-7658: Removing hostname resolution from TcpSocketCreatorAdapter

Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/4572 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org