You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by GitBox <gi...@apache.org> on 2021/01/14 08:01:30 UTC

[GitHub] [metamodel] arjansh commented on a change in pull request #247: Build on Travis fails most of the time

arjansh commented on a change in pull request #247:
URL: https://github.com/apache/metamodel/pull/247#discussion_r557147254



##########
File path: excel/src/test/java/org/apache/metamodel/excel/ExcelDataContextTest.java
##########
@@ -928,14 +970,15 @@ public void testInsertingValueOfValidColumnType() {
         assertTrue(dataSet.next());
     }
 
-    @Test(expected = MetaModelException.class)
+    @Test

Review comment:
       It never threw an exception. Because we were using JUnit3 the expected exception part of the annotation was ignored.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org