[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #198: [Baseline] Apply Baseline to iceberg-data #156

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #198: [Baseline] Apply Baseline to iceberg-data #156
URL: https://github.com/apache/incubator-iceberg/pull/198#discussion_r291819836
 
 

 ##########
 File path: data/src/main/java/org/apache/iceberg/data/avro/GenericReaders.java
 ##########
 @@ -111,19 +111,19 @@ public OffsetDateTime read(Decoder decoder, Object reuse) throws IOException {
   }
 
   private static class GenericRecordReader extends ValueReaders.StructReader<Record> {
-    private final StructType struct;
+    private final StructType record;
 
 Review comment:
   What about structType instead? In the context of a record reader, record sounds like it would not be a type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org