You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/05/19 03:51:00 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1499: [CELEBORN-594] Add new Ratis configs.
FMX opened a new pull request, #1499:
URL: https://github.com/apache/incubator-celeborn/pull/1499
### What changes were proposed in this pull request?
1. To set new configs introduced by recent Ratis upgrade.
2. Remove noisy logs.
### Why are the changes needed?
Ditto.
### Does this PR introduce _any_ user-facing change?
NO.
### How was this patch tested?
Cluster and UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1499: [CELEBORN-594] Add new Ratis configs.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1499:
URL: https://github.com/apache/incubator-celeborn/pull/1499#issuecomment-1553963437
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1499?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1499](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1499?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (55b97d7) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/aa817bdbebdd5346050ee722eefdf9919aa0eab5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (aa817bd) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
+ Coverage 45.27% 45.31% +0.04%
==========================================
Files 158 158
Lines 9721 9735 +14
Branches 959 959
==========================================
+ Hits 4400 4410 +10
- Misses 5033 5037 +4
Partials 288 288
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | `87.23% <100.00%> (+0.09%)` | :arrow_up: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1499/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1499: [CELEBORN-594] Add new Ratis configs.
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1499:
URL: https://github.com/apache/incubator-celeborn/pull/1499#discussion_r1198516505
##########
conf/log4j2.xml.template:
##########
@@ -53,5 +53,9 @@
<Appender-ref ref="stdout" level="WARN" />
<Appender-ref ref="file" level="WARN"/>
</Logger>
+ <Logger name="org.apache.ratis.server.RaftServerConfigKeys" level="WARN" additivity="false">
+ <Appender-ref ref="stdout" level="WARN" />
Review Comment:
nit: indent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1499: [CELEBORN-594] Eliminate Ratis noisy logs.
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1499:
URL: https://github.com/apache/incubator-celeborn/pull/1499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org