You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2011/04/12 19:46:05 UTC
[jira] [Created] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
FileContext createFlag combinations during create are not clearly defined
-------------------------------------------------------------------------
Key: HADOOP-7223
URL: https://issues.apache.org/jira/browse/HADOOP-7223
Project: Hadoop Common
Issue Type: Bug
Components: fs
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Fix For: 0.23.0
During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019051#comment-13019051 ]
Hadoop QA commented on HADOOP-7223:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476150/HADOOP-7223.1.patch
against trunk revision 1090485.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/344//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/344//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/344//console
This message is automatically generated.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019556#comment-13019556 ]
Hudson commented on HADOOP-7223:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #551 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/551/])
Undoing commit r1091613 for HADOOP-7223. FileContext createFlag combinations are not clearly defined.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Status: Patch Available (was: Open)
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Status: Open (was: Patch Available)
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020074#comment-13020074 ]
Hadoop QA commented on HADOOP-7223:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476379/HADOOP-7223.4.patch
against trunk revision 1092519.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/348//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/348//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/348//console
This message is automatically generated.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018995#comment-13018995 ]
Sanjay Radia commented on HADOOP-7223:
--------------------------------------
Thanks. And thanks for documenting the flags and cleaning up the exceptions and tests.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas reopened HADOOP-7223:
-------------------------------------
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018962#comment-13018962 ]
Sanjay Radia commented on HADOOP-7223:
--------------------------------------
+1, however I have the following minor suggestion for improvement.
Change the tests for exception to take advantage of Junit's @Test(expected=xxxx ...).
This will force you to create separate methods for each of the tests but it is easier to maintain.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Attachment: HADOOP-7223.2.patch
Updated patch.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020266#comment-13020266 ]
Hudson commented on HADOOP-7223:
--------------------------------
Integrated in Hadoop-Common-trunk #662 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/662/])
HADOOP-7223. FileContext createFlag combinations are not clearly defined. Contributed by Suresh Srinivas.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Attachment: HADOOP-7223.4.patch
Modified patch:
# Changed the file names created in the tests to that of test case name for easier debugging.
# CreateFlag OVERWRITE meant CREATE|OVERWRITE in the earlier version. Changed those instances to use OVERWRITE|CREATE.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025613#comment-13025613 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7223:
------------------------------------------------
Renaming Hadoop to Jaadoop? Sounds fun. :)
In CHANGES.txt,
{noformat}
-Hadoop Change Log
+Hn jaadoop Change Log
{noformat}
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026006#comment-13026006 ]
Suresh Srinivas commented on HADOOP-7223:
-----------------------------------------
Good catch :-) Fixed it.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I committed the patch.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018967#comment-13018967 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7223:
------------------------------------------------
We should also check for empty set. I know you got it already.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Attachment: HADOOP-7223.1.patch
Both comments taken care of in this new patch.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020164#comment-13020164 ]
Hudson commented on HADOOP-7223:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #554 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/554/])
HADOOP-7223. FileContext createFlag combinations are not clearly defined. Contributed by Suresh Srinivas.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020070#comment-13020070 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7223:
------------------------------------------------
+1
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Status: Patch Available (was: Open)
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019781#comment-13019781 ]
Hudson commented on HADOOP-7223:
--------------------------------
Integrated in Hadoop-Common-trunk #661 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/661/])
Undoing commit r1091613 for HADOOP-7223. FileContext createFlag combinations are not clearly defined.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019132#comment-13019132 ]
Hudson commented on HADOOP-7223:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #548 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/548/])
HADOOP-7223. FileContext createFlag combinations are not clearly defined. Contributed by Suresh Srinivas.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Sanjay Radia (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019053#comment-13019053 ]
Sanjay Radia commented on HADOOP-7223:
--------------------------------------
+1
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019081#comment-13019081 ]
Hadoop QA commented on HADOOP-7223:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476180/HADOOP-7223.2.patch
against trunk revision 1090485.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/345//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/345//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/345//console
This message is automatically generated.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Attachment: HADOOP-7223.patch
Attached patch makes the following changes:
# Added test for various CreateFlag combinations
# Removed redundant RawLocalFileSystem#primitiveCreate(), as the based implementation FileSystem#primitiveCreate() is identical.
# Added documentation and validation in {{CreateFlag}}
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Status: Open (was: Patch Available)
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Status: Patch Available (was: Reopened)
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.4.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019282#comment-13019282 ]
Hudson commented on HADOOP-7223:
--------------------------------
Integrated in Hadoop-Common-trunk #660 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/660/])
HADOOP-7223. FileContext createFlag combinations are not clearly defined. Contributed by Suresh Srinivas.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7223:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Status: Patch Available (was: Open)
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7223) FileContext createFlag
combinations during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018933#comment-13018933 ]
Suresh Srinivas commented on HADOOP-7223:
-----------------------------------------
Currently all the comination of createFlag and the expected behavior is not clearly defined in FileContext#create(). Here is my proposal on how the combination must behave the behavior a user needs:
CreateFlag specifies the file create semantic. Users can combine flags like:
EnumSet.of(CreateFlag.CREATE, CreateFlag.APPEND)
Use the CreateFlag as follows:
CREATE - to create a file if it does not exist, else throw FileAlreadyExists.
APPEND - to append to a file if it exists, else throw FileNotFoundException.
OVERWRITE - to truncate a file if it exists, else throw FileNotFoundException.
CREATE|APPEND - to create a file if it does not exist, else append to an existing file.
CREATE|OVERWRITE - to create a file if it does not exist, else overwrite an existing file.
Following combination is not valid and will result in HadoopIllegalArgumentException:
APPEND|OVERWRITE
CREATE|APPEND|OVERWRITE
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7223) FileContext createFlag combinations
during create are not clearly defined
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7223:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I committed the patch.
> FileContext createFlag combinations during create are not clearly defined
> -------------------------------------------------------------------------
>
> Key: HADOOP-7223
> URL: https://issues.apache.org/jira/browse/HADOOP-7223
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.23.0
>
> Attachments: HADOOP-7223.1.patch, HADOOP-7223.2.patch, HADOOP-7223.patch
>
>
> During file creation with FileContext, the expected behavior is not clearly defined for combination of createFlag EnumSet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira