You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/11 07:53:22 UTC

[GitHub] [arrow] sanjibansg opened a new pull request, #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

sanjibansg opened a new pull request, #14370:
URL: https://github.com/apache/arrow/pull/14370

   This PR fixes the `ToString()` method in the `Expression` class to handle functions with no arguments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14370:
URL: https://github.com/apache/arrow/pull/14370#issuecomment-1274256188

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] sanjibansg commented on a diff in pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
sanjibansg commented on code in PR #14370:
URL: https://github.com/apache/arrow/pull/14370#discussion_r992114012


##########
cpp/src/arrow/compute/exec/expression_test.cc:
##########
@@ -284,8 +284,7 @@ TEST(Expression, ToString) {
       "allow_time_overflow=false, allow_decimal_truncate=false, "
       "allow_float_truncate=false, allow_invalid_utf8=false})");
 
-  // NB: corrupted for nullary functions but we don't have any of those
-  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetif)");
+  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetify()");

Review Comment:
   added a test with `RandomOptions()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] sanjibansg commented on a diff in pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
sanjibansg commented on code in PR #14370:
URL: https://github.com/apache/arrow/pull/14370#discussion_r992105580


##########
cpp/src/arrow/compute/exec/expression_test.cc:
##########
@@ -284,8 +284,7 @@ TEST(Expression, ToString) {
       "allow_time_overflow=false, allow_decimal_truncate=false, "
       "allow_float_truncate=false, allow_invalid_utf8=false})");
 
-  // NB: corrupted for nullary functions but we don't have any of those
-  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetif)");
+  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetify()");

Review Comment:
   added a test with `RoundOptions()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14370:
URL: https://github.com/apache/arrow/pull/14370#issuecomment-1274256140

   https://issues.apache.org/jira/browse/ARROW-17973


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou merged pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14370:
URL: https://github.com/apache/arrow/pull/14370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14370:
URL: https://github.com/apache/arrow/pull/14370#issuecomment-1275574058

   Benchmark runs are scheduled for baseline = 3d7f2f22a0fc441a41b8fa971e11c0f4290ebb24 and contender = 7be5e95ede147cf52ebad6ff0e6f97f1548e77a4. 7be5e95ede147cf52ebad6ff0e6f97f1548e77a4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/957cce32ec794d6e965e5de0ec948891...df736223fc3544758e1f277367bb6673/)
   [Failed :arrow_down:0.56% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f345ff3d0a484802afb9869613c984a8...84144fe07afa41fdb0f6de058fbddf0a/)
   [Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4df1589ae6144e9e99e023421ff3b256...dd7e5edd08304dcdbafbc511fa4aa557/)
   [Finished :arrow_down:0.07% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bf993ba95ee54ea4a392fa4e930b2b0d...0d213623e4d04d47ae750be04aed9608/)
   Buildkite builds:
   [Finished] [`7be5e95e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1663)
   [Failed] [`7be5e95e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1682)
   [Failed] [`7be5e95e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1665)
   [Finished] [`7be5e95e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1676)
   [Finished] [`3d7f2f22` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1662)
   [Failed] [`3d7f2f22` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1681)
   [Failed] [`3d7f2f22` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1664)
   [Finished] [`3d7f2f22` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1675)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on a diff in pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14370:
URL: https://github.com/apache/arrow/pull/14370#discussion_r992046795


##########
cpp/src/arrow/compute/exec/expression_test.cc:
##########
@@ -284,8 +284,7 @@ TEST(Expression, ToString) {
       "allow_time_overflow=false, allow_decimal_truncate=false, "
       "allow_float_truncate=false, allow_invalid_utf8=false})");
 
-  // NB: corrupted for nullary functions but we don't have any of those
-  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetif)");
+  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetify()");

Review Comment:
   Can you also add a test with options?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] pitrou commented on a diff in pull request #14370: ARROW-17973: [C++] Expression::ToString wrong for nullary function call

Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14370:
URL: https://github.com/apache/arrow/pull/14370#discussion_r992106141


##########
cpp/src/arrow/compute/exec/expression_test.cc:
##########
@@ -284,8 +284,7 @@ TEST(Expression, ToString) {
       "allow_time_overflow=false, allow_decimal_truncate=false, "
       "allow_float_truncate=false, allow_invalid_utf8=false})");
 
-  // NB: corrupted for nullary functions but we don't have any of those
-  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetif)");
+  EXPECT_EQ(call("widgetify", {}).ToString(), "widgetify()");

Review Comment:
   Ok, but I meant a test for a nullary function call...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org