You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/30 15:32:07 UTC
[GitHub] [pulsar] cbornet opened a new pull request, #17353: [fix][flaky] Fix flakyness in testAutoSchemaFunction
cbornet opened a new pull request, #17353:
URL: https://github.com/apache/pulsar/pull/17353
### Motivation
`testAutoSchemaFunction` is flaky because `ensureSubscriptionCreated` will create a consumer to create the subscription.
By doing so it also adds a schema on the topic.
But that leads to a race when the function consumer uses AUTO_SCHEMA because the new schema is seen as incompatible if the function consumer is already subscribed (We get IncompatibleSchemaException : Topic does not have schema to check).
Note: the issue with the IncompatibleSchemaException is a bug and will be fixed in another PR.
### Modifications
Use PulsarAdmin to create the subscription instead of a consumer.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as `PulsarFunctionsTest`
### Does this pull request potentially affect one of the following parts:
no
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
fix
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #17353: [fix][flaky] Fix flakyness in testAutoSchemaFunction
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #17353:
URL: https://github.com/apache/pulsar/pull/17353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #17353: [fix][flaky] Fix flakyness in testAutoSchemaFunction
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #17353:
URL: https://github.com/apache/pulsar/pull/17353#issuecomment-1231856631
I hope it fixes the CI. Not totally sure about that. At least it now works on my machine...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #17353: [fix][flaky] Fix flakyness in testAutoSchemaFunction
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #17353:
URL: https://github.com/apache/pulsar/pull/17353#issuecomment-1232202363
/pulsar-bot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org