You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/04/17 09:30:25 UTC
DO NOT REPLY [Bug 53088] New: Give PoolCleaner TimerTask a better
name
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088
Bug #: 53088
Summary: Give PoolCleaner TimerTask a better name
Product: Tomcat Modules
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P2
Component: jdbc-pool
AssignedTo: dev@tomcat.apache.org
ReportedBy: 1983-01-06@gmx.net
Classification: Unclassified
Currently, the TimerTask has the thread name "PoolCleaner[<number>:<number>]".
This is not really helpful (I was not able to identify this therad with
VisualVM at first glance) and can be messed with Oracle JNDI PoolCleaner.
A clearer name would help a lot. Since this thread is a singleton, I do not
seed any need to display classloader id and startup time. I have attached a
patched against with a proposal for a better name.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 53088] Give PoolCleaner TimerTask a better name
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088
--- Comment #3 from Michael Osipov <19...@gmx.net> 2012-04-23 14:13:09 UTC ---
Filip,
partially agreed but why can't we still have a better name?
What about "Tomcat JDBC Pool Cleaner[<number>:<number>]"
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 53088] Give PoolCleaner TimerTask a better name
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088
Filip Hanik <fh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
--- Comment #2 from Filip Hanik <fh...@apache.org> 2012-04-23 13:57:51 UTC ---
I am marking this invalid since
1. Singleton is only a relative term to a classloader. An app that embeds this
library can start up two different pools in two different classloaders
2. The thread, even in a single class loader system can change names - since
the timer thread, while being a singleton, can be stopped, and then started as
pools start and stop throughout the runtime of the JVM.
The name currently helps identify what classloader started it, and what time it
started.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53088] Give PoolCleaner TimerTask a better name
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088
Filip Hanik <fh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Filip Hanik <fh...@apache.org> ---
Fixed in r1616639
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 53088] Give PoolCleaner TimerTask a better name
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088
--- Comment #1 from Michael Osipov <19...@gmx.net> 2012-04-17 07:31:02 UTC ---
Created attachment 28620
--> https://issues.apache.org/bugzilla/attachment.cgi?id=28620
Pool Cleaner name
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 53088] Give PoolCleaner TimerTask a better name
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088
Filip Hanik <fh...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |
--- Comment #4 from Filip Hanik <fh...@apache.org> 2012-04-23 14:27:54 UTC ---
Reopen, put in a more descriptive name
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 53088] Give PoolCleaner TimerTask a better name
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53088
--- Comment #6 from Michael Osipov <19...@gmx.net> ---
Finally, thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org