You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/18 14:24:29 UTC
[GitHub] [incubator-uniffle] xianjingfeng opened a new pull request, #167: Limit the speed of memory release when drop pending events
xianjingfeng opened a new pull request, #167:
URL: https://github.com/apache/incubator-uniffle/pull/167
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Limit the speed of memory release when drop pending events
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
OOM will happen if a large number of events need to be dropped, because usedMemory release immediately, but the speed of GC is not fast enough. #164
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Already added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #167: Limit the speed of memory release when drop pending events
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #167:
URL: https://github.com/apache/incubator-uniffle/pull/167#issuecomment-1220365378
A little confused about the effect of pr. Do you give some data on your production environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #167: Limit the speed of memory release when drop pending events
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #167:
URL: https://github.com/apache/incubator-uniffle/pull/167#issuecomment-1220429978
https://stackoverflow.com/questions/8719071/is-it-possible-to-get-outofmemoryerror-because-garbage-collection-too-slow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #167: Limit the speed of memory release when drop pending events
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on code in PR #167:
URL: https://github.com/apache/incubator-uniffle/pull/167#discussion_r950010992
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -111,26 +114,28 @@ public ShuffleFlushManager(ShuffleServerConf shuffleServerConf, String shuffleSe
processEventThread.setName("ProcessEventThread");
processEventThread.setDaemon(true);
processEventThread.start();
- // todo: extract a class named Service, and support stop method
- Thread thread = new Thread("PendingEventProcessThread") {
- @Override
- public void run() {
- for (; ; ) {
- try {
- processPendingEvents();
- processPendingEventIndex = (processPendingEventIndex + 1) % 1000;
- if (processPendingEventIndex == 0) {
- // todo: get sleep interval from configuration
- Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
- }
- } catch (Exception e) {
- LOG.error(getName() + " happened exception: ", e);
+ pendingEventProcesser = Executors.newSingleThreadScheduledExecutor(
+ ThreadUtils.getThreadFactory("PendingEventProcesser-%d"));
+ long sleepInterval = shuffleServerConf.get(ShuffleServerConf.PENDING_EVENT_CHECK_INTERVAL);
+ long memoryCapacity = shuffleServerConf.getSizeAsBytes(ShuffleServerConf.SERVER_BUFFER_CAPACITY);;
+ long memoryThreshold = Math.max(memoryCapacity / 10, 1024L * 1024 * 1024);
Review Comment:
Use 10 seconds to release all buffer, Maybe bigger than 10 is better, I am observing in our production environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #167: Limit the speed of memory release when drop pending events
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #167:
URL: https://github.com/apache/incubator-uniffle/pull/167#discussion_r949905016
##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -111,26 +114,28 @@ public ShuffleFlushManager(ShuffleServerConf shuffleServerConf, String shuffleSe
processEventThread.setName("ProcessEventThread");
processEventThread.setDaemon(true);
processEventThread.start();
- // todo: extract a class named Service, and support stop method
- Thread thread = new Thread("PendingEventProcessThread") {
- @Override
- public void run() {
- for (; ; ) {
- try {
- processPendingEvents();
- processPendingEventIndex = (processPendingEventIndex + 1) % 1000;
- if (processPendingEventIndex == 0) {
- // todo: get sleep interval from configuration
- Uninterruptibles.sleepUninterruptibly(1, TimeUnit.SECONDS);
- }
- } catch (Exception e) {
- LOG.error(getName() + " happened exception: ", e);
+ pendingEventProcesser = Executors.newSingleThreadScheduledExecutor(
+ ThreadUtils.getThreadFactory("PendingEventProcesser-%d"));
+ long sleepInterval = shuffleServerConf.get(ShuffleServerConf.PENDING_EVENT_CHECK_INTERVAL);
+ long memoryCapacity = shuffleServerConf.getSizeAsBytes(ShuffleServerConf.SERVER_BUFFER_CAPACITY);;
+ long memoryThreshold = Math.max(memoryCapacity / 10, 1024L * 1024 * 1024);
Review Comment:
Why do we divide by 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #167: Limit the speed of memory release when drop pending events
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #167:
URL: https://github.com/apache/incubator-uniffle/pull/167#issuecomment-1220485195
> Discuss in #164?
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng commented on pull request #167: Limit the speed of memory release when drop pending events
Posted by GitBox <gi...@apache.org>.
xianjingfeng commented on PR #167:
URL: https://github.com/apache/incubator-uniffle/pull/167#issuecomment-1220466488
Discuss in #164?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] xianjingfeng closed pull request #167: Limit the speed of memory release when drop pending events
Posted by GitBox <gi...@apache.org>.
xianjingfeng closed pull request #167: Limit the speed of memory release when drop pending events
URL: https://github.com/apache/incubator-uniffle/pull/167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org