You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2019/06/09 21:14:00 UTC

[hbase] branch master updated: HBASE-2284 Javadoc Warnings: Fix warnings coming due to @result tag in TestCoprocessorWhitelistMasterObserver (#256)

This is an automated email from the ASF dual-hosted git repository.

stack pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new 0838c35  HBASE-2284 Javadoc Warnings: Fix warnings coming due to @result tag in TestCoprocessorWhitelistMasterObserver (#256)
0838c35 is described below

commit 0838c356d46cffa3b09a32c49b739772a1fc423d
Author: syedmurtazahassan <sy...@gmail.com>
AuthorDate: Sun Jun 9 23:13:54 2019 +0200

    HBASE-2284 Javadoc Warnings: Fix warnings coming due to @result tag in TestCoprocessorWhitelistMasterObserver (#256)
---
 .../TestCoprocessorWhitelistMasterObserver.java    | 63 ++++++++++------------
 1 file changed, 28 insertions(+), 35 deletions(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCoprocessorWhitelistMasterObserver.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCoprocessorWhitelistMasterObserver.java
index d7a0277..53ad1fd 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCoprocessorWhitelistMasterObserver.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCoprocessorWhitelistMasterObserver.java
@@ -86,8 +86,8 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is not whitelisted
-   * @result An IOException should be thrown and caught
+   * which is not whitelisted.
+   * @exception Exception should be thrown and caught
    *         to show coprocessor is working as desired
    * @param whitelistedPaths A String array of paths to add in
    *         for the whitelisting configuration
@@ -127,9 +127,8 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is whitelisted
-   * @result The coprocessor should be added to the table
-   *         descriptor successfully
+   * which is whitelisted. The coprocessor should be added to
+   * the table descriptor successfully.
    * @param whitelistedPaths A String array of paths to add in
    *         for the whitelisting configuration
    * @param coprocessorPath A String to use as the
@@ -168,8 +167,8 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is not whitelisted
-   * @result An IOException should be thrown and caught
+   * which is not whitelisted.
+   * @exception Exception should be thrown and caught
    *         to show coprocessor is working as desired
    */
   @Test
@@ -180,10 +179,9 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table creation including a coprocessor path
-   * which is not whitelisted
-   * @result Coprocessor should be added to table descriptor
-   *         Table is disabled to avoid an IOException due to
-   *         the added coprocessor not actually existing on disk
+   * which is not whitelisted. Coprocessor should be added to
+   * table descriptor. Table is disabled to avoid an IOException due
+   * to the added coprocessor not actually existing on disk.
    */
   @Test
   public void testDifferentFileSystemNonWhitelisted() throws Exception {
@@ -193,10 +191,9 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is whitelisted
-   * @result Coprocessor should be added to table descriptor
-   *         Table is disabled to avoid an IOException due to
-   *         the added coprocessor not actually existing on disk
+   * which is whitelisted. Coprocessor should be added to table
+   * descriptor. Table is disabled to avoid an IOException due to
+   * the added coprocessor not actually existing on disk.
    */
   @Test
   public void testSchemeAndDirectorywhitelisted() throws Exception {
@@ -206,10 +203,9 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is whitelisted
-   * @result Coprocessor should be added to table descriptor
-   *         Table is disabled to avoid an IOException due to
-   *         the added coprocessor not actually existing on disk
+   * which is whitelisted. Coprocessor should be added to table
+   * descriptor. Table is disabled to avoid an IOException due to
+   * the added coprocessor not actually existing on disk.
    */
   @Test
   public void testSchemeWhitelisted() throws Exception {
@@ -219,10 +215,9 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is whitelisted
-   * @result Coprocessor should be added to table descriptor
-   *         Table is disabled to avoid an IOException due to
-   *         the added coprocessor not actually existing on disk
+   * which is whitelisted. Coprocessor should be added to table
+   * descriptor. Table is disabled to avoid an IOException due to
+   * the added coprocessor not actually existing on disk.
    */
   @Test
   public void testDFSNameWhitelistedWorks() throws Exception {
@@ -232,10 +227,9 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is whitelisted
-   * @result Coprocessor should be added to table descriptor
-   *         Table is disabled to avoid an IOException due to
-   *         the added coprocessor not actually existing on disk
+   * which is whitelisted. Coprocessor should be added to table
+   * descriptor. Table is disabled to avoid an IOException due to
+   * the added coprocessor not actually existing on disk.
    */
   @Test
   public void testDFSNameNotWhitelistedFails() throws Exception {
@@ -245,10 +239,9 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table modification adding a coprocessor path
-   * which is whitelisted
-   * @result Coprocessor should be added to table descriptor
-   *         Table is disabled to avoid an IOException due to
-   *         the added coprocessor not actually existing on disk
+   * which is whitelisted. Coprocessor should be added to table
+   * descriptor. Table is disabled to avoid an IOException due to
+   * the added coprocessor not actually existing on disk.
    */
   @Test
   public void testBlanketWhitelist() throws Exception {
@@ -258,8 +251,8 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table creation including a coprocessor path
-   * which is not whitelisted
-   * @result Table will not be created due to the offending coprocessor
+   * which is not whitelisted. Table will not be created due to the
+   * offending coprocessor.
    */
   @Test
   public void testCreationNonWhitelistedCoprocessorPath() throws Exception {
@@ -303,8 +296,8 @@ public class TestCoprocessorWhitelistMasterObserver extends SecureTestUtil {
 
   /**
    * Test a table creation including a coprocessor path
-   * which is on the classpath
-   * @result Table will be created with the coprocessor
+   * which is on the classpath. Table will be created with the
+   * coprocessor.
    */
   @Test
   public void testCreationClasspathCoprocessor() throws Exception {