You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/22 15:42:04 UTC

[GitHub] [arrow-datafusion] msathis commented on a change in pull request #22: [Ballista] Docker files for ui

msathis commented on a change in pull request #22:
URL: https://github.com/apache/arrow-datafusion/pull/22#discussion_r618517647



##########
File path: ballista/ui/scheduler/.dockerignore
##########
@@ -0,0 +1,3 @@
+node_modules
+build
+.dockerignore

Review comment:
       Not necessarily. Just avoids copying it while building the image. Adding it or not adding it doesn't make big difference. But this link https://codefresh.io/docker-tutorial/not-ignore-dockerignore-2/ suggests to not ignore it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org