You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Jie Yu (JIRA)" <ji...@apache.org> on 2016/08/10 18:04:20 UTC
[jira] [Created] (MESOS-6021) Consolidate two
`Containerizer::launch` methods into one.
Jie Yu created MESOS-6021:
-----------------------------
Summary: Consolidate two `Containerizer::launch` methods into one.
Key: MESOS-6021
URL: https://issues.apache.org/jira/browse/MESOS-6021
Project: Mesos
Issue Type: Task
Reporter: Jie Yu
Looks like keeping both of them is not necessary.
{code}
// Launch a containerized executor. Returns true if launching this
// ExecutorInfo is supported and it has been launched, otherwise
// false or a failure is something went wrong.
virtual process::Future<bool> launch(
const ContainerID& containerId,
const ExecutorInfo& executorInfo,
const std::string& directory,
const Option<std::string>& user,
const SlaveID& slaveId,
const process::PID<Slave>& slavePid,
bool checkpoint) = 0;
// Launch a containerized task. Returns true if launching this
// TaskInfo/ExecutorInfo is supported and it has been launched,
// otherwise false or a failure is something went wrong.
// TODO(nnielsen): Obsolete the executorInfo argument when the slave
// doesn't require executors to run standalone tasks.
virtual process::Future<bool> launch(
const ContainerID& containerId,
const TaskInfo& taskInfo,
const ExecutorInfo& executorInfo,
const std::string& directory,
const Option<std::string>& user,
const SlaveID& slaveId,
const process::PID<Slave>& slavePid,
bool checkpoint) = 0;
{code}
We can just make `taskInfo` optional.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)