[GitHub] [airflow] ashb commented on a change in pull request #16711: Add error message to dag dependency view

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #16711:
URL: https://github.com/apache/airflow/pull/16711#discussion_r662202982



##########
File path: airflow/www/static/js/dag_dependencies.js
##########
@@ -37,6 +37,15 @@ const g = new dagreD3.graphlib.Graph()
   })
   .setDefaultEdgeLabel(() => ({ lineInterpolate: 'basis' }));
 
+// Sometimes the data doesn't load when the scheduler isn't running.
+if (!nodes.length) {
+  $('#error').show();
+  $('#error_msg').text(`
+    There was an issue loading dependencies.
+    Make sure you have dags loaded and that everything is running, then try again.

Review comment:
       I'm still not happy with this case when there are no DAGs -- i.e. a fresh install with out any dags, and with load_examples off -- in that case it shouldn't really show an error; it should just show nothing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org