You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Norm Deane <no...@vanderbilt.edu> on 2003/09/02 14:56:37 UTC

RE: [beanutils][collections] Transformer, Predicate, and Closure Implementation

Thanks to you Robert for taking the time to look over my submission and
taking the time to incorporate it!

Forgive the stupid newbie question but... I would like to become more
active in the Commons, Struts, or Maven projects but am not sure where
to start.  I've read the 'Get Involved' section and scanned the Apache
Bug Database and JIRA (for Maven) but I'm not sure where my help is
needed most and I don't want to step on toes by working issues that
other people are working.

Any suggestions would be appreciated.

-- 
Norm Deane
MIS Consultant
Vanderbilt University
(615) 322-7855
norm.deane@vanderbilt.edu 

-----Original Message-----
From: robert burrell donkin
[mailto:robertburrelldonkin@blueyonder.co.uk] 
Sent: Thursday, August 28, 2003 3:15 PM
To: Jakarta Commons Developers List
Subject: Re: [beanutils][collections] Transformer, Predicate, and
Closure Implementation


hi norm

committed. many thanks.

i've added some documentation into the beanutils package.html (which is 
where the main beanutils documentation lives). feel free to expand and 
enhance it if you wish :)

- robert

On Wednesday, August 27, 2003, at 04:36 PM, Norm Deane wrote:

> I've attached a zip file which includes the java files for the 
> Predicate, Closure, and Transformer along with their respective test 
> cases.  I wasn't sure what release these might make it into so I did 
> NOT include an @since in my JavaDocs.  I also included a patch for a 
> couple very minor changes I made to TestBean to support some of my 
> test cases.
>
> --Norm
>
> --
> Norm Deane
> MIS Consultant
> Vanderbilt University
> (615) 322-7855
> norm.deane@vanderbilt.edu
>
> -----Original Message-----
> From: Norm Deane [mailto:norm.deane@vanderbilt.edu]
> Sent: Tuesday, August 26, 2003 2:00 PM
> To: 'Jakarta Commons Developers List'
> Subject: RE: [beanutils][collections] Transformer, Predicate, and 
> Closure Implementation
>
>
> Not a problem.  I will add the license and e-mail the new files along 
> with test cases later this week.  Unless someone speaks up I will 
> leave the package as is.
>
> --Norm
>
> --
> Norm Deane
> MIS Consultant
> Vanderbilt University
> (615) 322-7855
> norm.deane@vanderbilt.edu
>
> -----Original Message-----
> From: robert burrell donkin 
> [mailto:robertburrelldonkin@blueyonder.co.uk]
> Sent: Sunday, August 24, 2003 4:04 AM
> To: Jakarta Commons Developers List
> Subject: Re: [beanutils][collections] Transformer, Predicate, and 
> Closure Implementation
>
>
> hi norm
>
> i've taken a look and these look pretty cool and i'd be interested in 
> adding them to beanutils. there are a few issues that should be 
> discussed before i'd be willing to make this happen:
>
> 1. the apache license has not been included at the top of each file. 
> since this assigns copyright to the ASF it's taken as a sufficient 
> indication that you are willing to donate the code. please either 
> resubmit with the
>
> ASF license at the top of each source file or confirm to the list that

> you want to donate this code.
>
> 2, would you be willing to create and donate some unit tests for these

> class? (all new code should have unit tests and if you're not willing 
> to
>
> create them that means a committer must which is extra work and may 
> lead
>
> to the item sinking down the list of priorities...)
>
> 3. packaging. as submitted, these classes will be placed in the root 
> beanutils package. if there are going to be a lot of other stuff along

> similar lines, maybe it'd be better to create a new package. comments 
> anyone?
>
> - robert
>
> On Thursday, August 21, 2003, at 06:45 PM, Norm Deane wrote:
>
>> I recently implemented a Closure, Transformer, and Predicate which 
>> make use of PropertyUtils to provide some useful functionality when 
>> dealing with Collections of beans.  I wanted to offer them up as a 
>> candidate for the BeanUtils package and/or get some feedback from the

>> list.
>>
>> --> BeanPropertyValueChangeClosure is an implementation of
>> Closure</code> that updates a specified property on the object 
>> provided with a specified value.
>>
>> --> BeanPropertyValueEqualsPredicate is an implementation of 
>> --> Predicate
>> that evaluates a property value on the object provided against a 
>> specified value and returns true if equal; false otherwise.
>>
>> --> BeanToPropertyValueTransformer is an implementation of 
>> --> Transformer
>> that transforms the object provided by returning the value of a 
>> specified property of the object.
>>
>>
>> Thanks,
>>
>> Norm
>>
>>
>> --
>> Norm Deane
>> MIS Consultant
>> Vanderbilt University
>> (615) 322-7855
>> norm.deane@vanderbilt.edu
>>  
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>   
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org



Re: [beanutils][collections] Transformer, Predicate, and Closure Implementation

Posted by Stephen Colebourne <sc...@btopenworld.com>.
You seem to have an interest in [collections], so perhaps you would fancy
looking at the Bugzilla. I am trying to pull strands together for a release,
so any javadoc checking, extra tests, or new classes from bugzilla would be
great.

If you find something, I suggest talking to the mailing list to check
current views. Don't forget to prefix with [collections] ;-)

Stephen

----- Original Message -----
From: "Norm Deane" <no...@vanderbilt.edu>
> Thanks to you Robert for taking the time to look over my submission and
> taking the time to incorporate it!
>
> Forgive the stupid newbie question but... I would like to become more
> active in the Commons, Struts, or Maven projects but am not sure where
> to start.  I've read the 'Get Involved' section and scanned the Apache
> Bug Database and JIRA (for Maven) but I'm not sure where my help is
> needed most and I don't want to step on toes by working issues that
> other people are working.
>
> Any suggestions would be appreciated.
>
> --
> Norm Deane
> MIS Consultant
> Vanderbilt University
> (615) 322-7855
> norm.deane@vanderbilt.edu
>
> -----Original Message-----
> From: robert burrell donkin
> [mailto:robertburrelldonkin@blueyonder.co.uk]
> Sent: Thursday, August 28, 2003 3:15 PM
> To: Jakarta Commons Developers List
> Subject: Re: [beanutils][collections] Transformer, Predicate, and
> Closure Implementation
>
>
> hi norm
>
> committed. many thanks.
>
> i've added some documentation into the beanutils package.html (which is
> where the main beanutils documentation lives). feel free to expand and
> enhance it if you wish :)
>
> - robert
>
> On Wednesday, August 27, 2003, at 04:36 PM, Norm Deane wrote:
>
> > I've attached a zip file which includes the java files for the
> > Predicate, Closure, and Transformer along with their respective test
> > cases.  I wasn't sure what release these might make it into so I did
> > NOT include an @since in my JavaDocs.  I also included a patch for a
> > couple very minor changes I made to TestBean to support some of my
> > test cases.
> >
> > --Norm
> >
> > --
> > Norm Deane
> > MIS Consultant
> > Vanderbilt University
> > (615) 322-7855
> > norm.deane@vanderbilt.edu
> >
> > -----Original Message-----
> > From: Norm Deane [mailto:norm.deane@vanderbilt.edu]
> > Sent: Tuesday, August 26, 2003 2:00 PM
> > To: 'Jakarta Commons Developers List'
> > Subject: RE: [beanutils][collections] Transformer, Predicate, and
> > Closure Implementation
> >
> >
> > Not a problem.  I will add the license and e-mail the new files along
> > with test cases later this week.  Unless someone speaks up I will
> > leave the package as is.
> >
> > --Norm
> >
> > --
> > Norm Deane
> > MIS Consultant
> > Vanderbilt University
> > (615) 322-7855
> > norm.deane@vanderbilt.edu
> >
> > -----Original Message-----
> > From: robert burrell donkin
> > [mailto:robertburrelldonkin@blueyonder.co.uk]
> > Sent: Sunday, August 24, 2003 4:04 AM
> > To: Jakarta Commons Developers List
> > Subject: Re: [beanutils][collections] Transformer, Predicate, and
> > Closure Implementation
> >
> >
> > hi norm
> >
> > i've taken a look and these look pretty cool and i'd be interested in
> > adding them to beanutils. there are a few issues that should be
> > discussed before i'd be willing to make this happen:
> >
> > 1. the apache license has not been included at the top of each file.
> > since this assigns copyright to the ASF it's taken as a sufficient
> > indication that you are willing to donate the code. please either
> > resubmit with the
> >
> > ASF license at the top of each source file or confirm to the list that
>
> > you want to donate this code.
> >
> > 2, would you be willing to create and donate some unit tests for these
>
> > class? (all new code should have unit tests and if you're not willing
> > to
> >
> > create them that means a committer must which is extra work and may
> > lead
> >
> > to the item sinking down the list of priorities...)
> >
> > 3. packaging. as submitted, these classes will be placed in the root
> > beanutils package. if there are going to be a lot of other stuff along
>
> > similar lines, maybe it'd be better to create a new package. comments
> > anyone?
> >
> > - robert
> >
> > On Thursday, August 21, 2003, at 06:45 PM, Norm Deane wrote:
> >
> >> I recently implemented a Closure, Transformer, and Predicate which
> >> make use of PropertyUtils to provide some useful functionality when
> >> dealing with Collections of beans.  I wanted to offer them up as a
> >> candidate for the BeanUtils package and/or get some feedback from the
>
> >> list.
> >>
> >> --> BeanPropertyValueChangeClosure is an implementation of
> >> Closure</code> that updates a specified property on the object
> >> provided with a specified value.
> >>
> >> --> BeanPropertyValueEqualsPredicate is an implementation of
> >> --> Predicate
> >> that evaluates a property value on the object provided against a
> >> specified value and returns true if equal; false otherwise.
> >>
> >> --> BeanToPropertyValueTransformer is an implementation of
> >> --> Transformer
> >> that transforms the object provided by returning the value of a
> >> specified property of the object.
> >>
> >>
> >> Thanks,
> >>
> >> Norm
> >>
> >>
> >> --
> >> Norm Deane
> >> MIS Consultant
> >> Vanderbilt University
> >> (615) 322-7855
> >> norm.deane@vanderbilt.edu
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


Re: [beanutils][collections] Transformer, Predicate, and Closure Implementation

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On Tuesday, September 2, 2003, at 01:56 PM, Norm Deane wrote:

> Thanks to you Robert for taking the time to look over my submission and
> taking the time to incorporate it!
>
> Forgive the stupid newbie question but... I would like to become more
> active in the Commons, Struts, or Maven projects but am not sure where
> to start.  I've read the 'Get Involved' section and scanned the Apache
> Bug Database and JIRA (for Maven) but I'm not sure where my help is
> needed most and I don't want to step on toes by working issues that
> other people are working.

hi norm

this is not really a stupid newbie question. the apache answer is find an 
itch and patch it! this is easy to say but less easy to practice.

apache is more decentralized than many other open source organization so 
you might need more patience and be more willing to take the initiative. 
one description that's often repeated is that it's a do-ocracy rather than 
a dem-ocracy.

what i usually do (where i'm not a committer) is find something i want to 
do and then post a 'hey - anyone mind if i do this?' to avoid stepping on 
anyone's toes.

if you're interested in maven then a lot of the developers hand around on 
irc so that's a good place to hang around to find out the latest news and 
who's working on what. if you've got a particular maven itch then that's a 
good place to ask.

i don't think that there is a component in commons that has enough 
developers.

if you're interested in the commons then you'll find that different 
components are quite different - even if developed by the same people. 
beanutils is very widely used and very mature. there is a very big list of 
enhancements and patches but it takes a long time to review them since the 
consequences of introduced bugs is pretty serious.

at the other end of the spectrum are commons-resources≤ commons-reflect 
and commons-math. these are new and need a lot of work. it's easier to 
commit patches for these and the impact a new developer could have on 
these components would be bigger than for others.

in the middle are components like collections and lang. these are still 
growing pretty quickly but they are widely used and so changes to the core 
are likely to be reviewed very carefully.

hope this helps and i'd like to encourage you to get involved.

- robert