You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 15:39:42 UTC
[GitHub] [arrow] lidavidm opened a new pull request, #14212: ARROW-17787: [Java] Fix Javadoc build
lidavidm opened a new pull request, #14212:
URL: https://github.com/apache/arrow/pull/14212
* Don't document the javadocs to avoid errors when there is nothing documentable in the javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14212: ARROW-17787: [Java] Fix Javadoc build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14212:
URL: https://github.com/apache/arrow/pull/14212#issuecomment-1255585557
https://issues.apache.org/jira/browse/ARROW-17787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm merged pull request #14212: ARROW-17787: [Java] Fix Javadoc build
Posted by GitBox <gi...@apache.org>.
lidavidm merged PR #14212:
URL: https://github.com/apache/arrow/pull/14212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14212: ARROW-17787: [Java] Fix Javadoc build
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14212:
URL: https://github.com/apache/arrow/pull/14212#issuecomment-1256614846
Benchmark runs are scheduled for baseline = 485128f089e945fd836bdebf30f80fd7fa762500 and contender = bed6f8e594093d59aaaed8df3d31d4c0ec905182. bed6f8e594093d59aaaed8df3d31d4c0ec905182 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/df1cda9e393541fdb3d07dba36015f82...6341c1bb9190423f95d2337632a57bba/)
[Failed :arrow_down:0.61% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f4bb00a64c0149279e9e3cf7bfa05fd5...15e8a1f24b8d4805bf8a61f98ed47763/)
[Failed :arrow_down:0.55% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/45f0668a33a947f4ad19f7a0057147b8...c6b704b522b64bec819cdd390a13683f/)
[Finished :arrow_down:0.25% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c2aecf40069c431c8ee1c9839b2841cb...d2bb72f50cae4d039f981ce357a3d8db/)
Buildkite builds:
[Finished] [`bed6f8e5` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1555)
[Finished] [`bed6f8e5` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1573)
[Failed] [`bed6f8e5` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1556)
[Finished] [`bed6f8e5` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1569)
[Finished] [`485128f0` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1554)
[Failed] [`485128f0` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1572)
[Failed] [`485128f0` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1555)
[Finished] [`485128f0` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1568)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #14212: ARROW-17787: [Java] Fix Javadoc build
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #14212:
URL: https://github.com/apache/arrow/pull/14212#discussion_r978187992
##########
java/pom.xml:
##########
@@ -688,7 +688,6 @@
<reportSet><!-- by default, id = "default" -->
<reports><!-- select non-aggregate reports -->
<report>javadoc</report>
- <report>test-javadoc</report>
Review Comment:
@lidavidm just for my understanding: why this fixes the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #14212: ARROW-17787: [Java] Fix Javadoc build
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #14212:
URL: https://github.com/apache/arrow/pull/14212#discussion_r978190978
##########
java/pom.xml:
##########
@@ -688,7 +688,6 @@
<reportSet><!-- by default, id = "default" -->
<reports><!-- select non-aggregate reports -->
<report>javadoc</report>
- <report>test-javadoc</report>
Review Comment:
Javadoc errors if it doesn't find any public classes to document, JUnit 5 means that test classes no longer need to be public, so the easiest solution is to just not document test code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on a diff in pull request #14212: ARROW-17787: [Java] Fix Javadoc build
Posted by GitBox <gi...@apache.org>.
vibhatha commented on code in PR #14212:
URL: https://github.com/apache/arrow/pull/14212#discussion_r978191913
##########
java/pom.xml:
##########
@@ -688,7 +688,6 @@
<reportSet><!-- by default, id = "default" -->
<reports><!-- select non-aggregate reports -->
<report>javadoc</report>
- <report>test-javadoc</report>
Review Comment:
Got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org