You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/10/09 11:08:35 UTC

[GitHub] [kylin] ggKe opened a new pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

ggKe opened a new pull request #1438:
URL: https://github.com/apache/kylin/pull/1438


   ## Proposed changes
   
   1、Clear the recordCachePool when the deadline has reached.
   2、Add timeout for the recordCachePool offer.
   https://issues.apache.org/jira/projects/KYLIN/issues/KYLIN-4771?filter=reportedbyme
   
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] ggKe commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

Posted by GitBox <gi...@apache.org>.
ggKe commented on pull request #1438:
URL: https://github.com/apache/kylin/pull/1438#issuecomment-706552143


   > Hello @ggKe , I have checked your patch, your patch look good to me. But there are some UT failure, could you please help to fix them?
   > 
   > Following is part of log:
   > 
   > ```
   > [�[1;34mINFO�[m] �[1;32mTests run: �[0;1;32m1�[m, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.242 s - in org.apache.kylin.stream.core.storage.�[1mRecordsSerDeTest�[m
   > [�[1;34mINFO�[m] Running org.apache.kylin.stream.core.storage.�[1mCheckPointStoreTest�[m
   > client:0 round266 scan finished
   > client:1 round269 scan finished
   > CheckPoint{sourceConsumePosition='{"1":30000,"2":40000,"3":50000}', persistedIndexes={1602241200000=1, 1602241199999=2, 1602241199998=3}, longLatencyInfo=LongLatencyInfo{longLatencyEventCnts={}, totalLongLatencyEventCnt=0}, segmentSourceStartPosition={1602241200000={"1":10000,"2":20000,"3":30000}}, checkPointTime=1602242847871, totalCount=1000000, checkPointCount=50000}
   > going to delete checkpoint file CP-1602201600000
   > going to delete checkpoint file CP-1602288000000
   > going to delete checkpoint file CP-1602374400000
   > going to delete checkpoint file CP-1602460800000
   > going to delete checkpoint file CP-1602547200000
   > CheckPoint{sourceConsumePosition='{"1":10000,"2":20000,"3":30000}', persistedIndexes={1602241200000=1, 1602241199999=2, 1602241199998=3}, longLatencyInfo=LongLatencyInfo{longLatencyEventCnts={}, totalLongLatencyEventCnt=0}, segmentSourceStartPosition={1602241200000={"1":10000,"2":20000,"3":30000}}, checkPointTime=1603020447894, totalCount=1000000, checkPointCount=50000}
   > [�[1;34mINFO�[m] �[1;32mTests run: �[0;1;32m3�[m, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.028 s - in org.apache.kylin.stream.core.storage.�[1mCheckPointStoreTest�[m
   > [�[1;34mINFO�[m] 
   > [�[1;34mINFO�[m] Results:
   > [�[1;34mINFO�[m] 
   > [�[1;31mERROR�[m] �[1;31mFailures: �[m
   > [�[1;31mERROR�[m] �[1;31m  StreamingSegmentManagerTest.testAddEventAndScan:120 expected:<80000> but was:<30007>�[m
   > [�[1;31mERROR�[m] �[1;31m  StreamingSegmentManagerTest.testIndexFilter:182 expected:<153298[080]0000> but was:<153298[104]0000>�[m
   > [�[1;34mINFO�[m] 
   > [�[1;31mERROR�[m] �[1;31mTests run: 29, Failures: 2, Errors: 0, Skipped: 0�[m
   > [�[1;34mINFO�[m] 
   > [�[1;34mINFO�[m] 
   > [�[1;34mINFO�[m] �[1m------------------------------------------------------------------------�[m
   > [�[1;34mINFO�[m] �[1mSkipping Apache Kylin�[m
   > [�[1;34mINFO�[m] This project has been banned from the build due to previous failures.
   > [�[1;34mINFO�[m] �[1m------------------------------------------------------------------------�[m
   > [�[1;34mINFO�[m] �[1m------------------------------------------------------------------------�[m
   > [�[1;34mINFO�[m] �[1mReactor Summary:�[m
   > [�[1;34mINFO�[m] 
   > [�[1;34mINFO�[m] Apache Kylin 3.1.1-SNAPSHOT ........................ �[1;32mSUCCESS�[m [  3.516 s]
   > [�[1;34mINFO�[m] Apache Kylin - kylin External ...................... �[1;32mSUCCESS�[m [  9.946 s]
   > [�[1;34mINFO�[m] Apache Kylin - Core Common ......................... �[1;32mSUCCESS�[m [ 22.354 s]
   > [�[1;34mINFO�[m] Apache Kylin - Core Metadata ....................... �[1;32mSUCCESS�[m [ 48.745 s]
   > [�[1;34mINFO�[m] Apache Kylin - Core Dictionary ..................... �[1;32mSUCCESS�[m [03:16 min]
   > [�[1;34mINFO�[m] Apache Kylin - Core Cube ........................... �[1;32mSUCCESS�[m [02:19 min]
   > [�[1;34mINFO�[m] Apache Kylin - Core Metrics ........................ �[1;32mSUCCESS�[m [  5.364 s]
   > [�[1;34mINFO�[m] Apache Kylin - Core Job ............................ �[1;32mSUCCESS�[m [01:08 min]
   > [�[1;34mINFO�[m] Apache Kylin - Core Storage ........................ �[1;32mSUCCESS�[m [  9.280 s]
   > [�[1;34mINFO�[m] Apache Kylin - Stream Core ......................... �[1;31mFAILURE�[m [01:02 min]
   > [�[1;34mINFO�[m] Apache Kylin - MapReduce Engine .................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Spark Engine ........................ �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Flink Engine ........................ �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Hive Source ......................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - DataSource SDK ...................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Jdbc Source ......................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Kafka Source ........................ �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Cache ............................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - HBase Storage ....................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Query ............................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Metrics Reporter Hive ............... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Metrics Reporter Kafka .............. �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Stream Source Kafka ................. �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Stream Coordinator .................. �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Stream Receiver ..................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Stream Storage ...................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - REST Server Base .................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Tool ................................ �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Cube Migration Service .............. �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - REST Server ......................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - JDBC Driver ......................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Assembly ............................ �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Tool Assembly ....................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Integration Test .................... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] Apache Kylin - Tomcat Extension 3.1.1-SNAPSHOT ..... �[1;33mSKIPPED�[m
   > [�[1;34mINFO�[m] �[1m------------------------------------------------------------------------�[m
   > [�[1;34mINFO�[m] �[1;31mBUILD FAILURE�[m
   > [�[1;34mINFO�[m] �[1m------------------------------------------------------------------------�[m
   > [�[1;34mINFO�[m] Total time: 09:28 min
   > [�[1;34mINFO�[m] Finished at: 2020-10-09T11:27:28Z
   > [�[1;34mINFO�[m] �[1m------------------------------------------------------------------------�[m
   > [�[1;31mERROR�[m] Failed to execute goal �[32morg.apache.maven.plugins:maven-surefire-plugin:2.21.0:test�[m �[1m(default-test)�[m on project �[36mkylin-stream-core�[m: �[1;31mThere are test failures.�[m
   > [�[1;31mERROR�[m] �[1;31m�[m
   > [�[1;31mERROR�[m] �[1;31mPlease refer to /home/travis/build/apache/kylin/stream-core/../target/surefire-reports for the individual test results.�[m
   > [�[1;31mERROR�[m] �[1;31mPlease refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.�[m
   > [�[1;31mERROR�[m] -> �[1m[Help 1]�[m
   > �[1;31morg.apache.maven.lifecycle.LifecycleExecutionException�[m: �[1;31mFailed to execute goal �[32morg.apache.maven.plugins:maven-surefire-plugin:2.21.0:test�[m �[1m(default-test)�[m on project �[36mkylin-stream-core�[m: �[1;31mThere are test failures.
   > ```
   
   hi,@hit-lacus,I have fixed the code , project can successfuly pass the UT now.
   [INFO] Apache Kylin ....................................... SUCCESS [  3.201 s]
   [INFO] Apache Kylin - kylin External ...................... SUCCESS [  6.257 s]
   [INFO] Apache Kylin - Core Common ......................... SUCCESS [ 19.132 s]
   [INFO] Apache Kylin - Core Metadata ....................... SUCCESS [ 48.198 s]
   [INFO] Apache Kylin - Core Dictionary ..................... SUCCESS [09:10 min]
   [INFO] Apache Kylin - Core Cube ........................... SUCCESS [02:12 min]
   [INFO] Apache Kylin - Core Metrics ........................ SUCCESS [  5.826 s]
   [INFO] Apache Kylin - Core Job ............................ SUCCESS [01:08 min]
   [INFO] Apache Kylin - Core Storage ........................ SUCCESS [  7.384 s]
   [INFO] Apache Kylin - Stream Core ......................... SUCCESS [ 46.880 s]
   [INFO] Apache Kylin - MapReduce Engine .................... SUCCESS [ 46.244 s]
   [INFO] Apache Kylin - Spark Engine ........................ SUCCESS [ 14.603 s]
   [INFO] Apache Kylin - Flink Engine ........................ SUCCESS [ 10.946 s]
   [INFO] Apache Kylin - Hive Source ......................... SUCCESS [  8.388 s]
   [INFO] Apache Kylin - DataSource SDK ...................... SUCCESS [ 11.289 s]
   [INFO] Apache Kylin - Jdbc Source ......................... SUCCESS [ 18.348 s]
   [INFO] Apache Kylin - Kafka Source ........................ SUCCESS [  6.703 s]
   [INFO] Apache Kylin - Cache ............................... SUCCESS [  9.287 s]
   [INFO] Apache Kylin - HBase Storage ....................... SUCCESS [ 35.486 s]
   [INFO] Apache Kylin - Query ............................... SUCCESS [ 13.792 s]
   [INFO] Apache Kylin - Metrics Reporter Hive ............... SUCCESS [  8.919 s]
   [INFO] Apache Kylin - Metrics Reporter Kafka .............. SUCCESS [  5.474 s]
   [INFO] Apache Kylin - Stream Source Kafka ................. SUCCESS [  5.353 s]
   [INFO] Apache Kylin - Stream Coordinator .................. SUCCESS [ 18.839 s]
   [INFO] Apache Kylin - Stream Receiver ..................... SUCCESS [ 15.744 s]
   [INFO] Apache Kylin - Stream Storage ...................... SUCCESS [  1.717 s]
   [INFO] Apache Kylin - REST Server Base .................... SUCCESS [ 27.156 s]
   [INFO] Apache Kylin - Tool ................................ SUCCESS [ 16.371 s]
   [INFO] Apache Kylin - Cube Migration Service .............. SUCCESS [  2.950 s]
   [INFO] Apache Kylin - REST Server ......................... SUCCESS [03:42 min]
   [INFO] Apache Kylin - JDBC Driver ......................... SUCCESS [  8.377 s]
   [INFO] Apache Kylin - Assembly ............................ SUCCESS [ 19.827 s]
   [INFO] Apache Kylin - Tool Assembly ....................... SUCCESS [  4.140 s]
   [INFO] Apache Kylin - Integration Test .................... SUCCESS [ 20.800 s]
   [INFO] Apache Kylin - Tomcat Extension .................... SUCCESS [  1.077 s]
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  24:03 min
   [INFO] Finished at: 2020-10-10T21:37:31+08:00
   [INFO] ------------------------------------------------------------------------
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus merged pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1438:
URL: https://github.com/apache/kylin/pull/1438


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1438:
URL: https://github.com/apache/kylin/pull/1438#issuecomment-706512995


   Hello @ggKe , I have checked your patch, your patch look good to me. But there are some UT failure, could you please help to fix them? 
   
   Following is part of log:
   
   
   ```sh
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.242 s - in org.apache.kylin.stream.core.storage.RecordsSerDeTest
   [INFO] Running org.apache.kylin.stream.core.storage.CheckPointStoreTest
   client:0 round266 scan finished
   client:1 round269 scan finished
   CheckPoint{sourceConsumePosition='{"1":30000,"2":40000,"3":50000}', persistedIndexes={1602241200000=1, 1602241199999=2, 1602241199998=3}, longLatencyInfo=LongLatencyInfo{longLatencyEventCnts={}, totalLongLatencyEventCnt=0}, segmentSourceStartPosition={1602241200000={"1":10000,"2":20000,"3":30000}}, checkPointTime=1602242847871, totalCount=1000000, checkPointCount=50000}
   going to delete checkpoint file CP-1602201600000
   going to delete checkpoint file CP-1602288000000
   going to delete checkpoint file CP-1602374400000
   going to delete checkpoint file CP-1602460800000
   going to delete checkpoint file CP-1602547200000
   CheckPoint{sourceConsumePosition='{"1":10000,"2":20000,"3":30000}', persistedIndexes={1602241200000=1, 1602241199999=2, 1602241199998=3}, longLatencyInfo=LongLatencyInfo{longLatencyEventCnts={}, totalLongLatencyEventCnt=0}, segmentSourceStartPosition={1602241200000={"1":10000,"2":20000,"3":30000}}, checkPointTime=1603020447894, totalCount=1000000, checkPointCount=50000}
   [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.028 s - in org.apache.kylin.stream.core.storage.CheckPointStoreTest
   [INFO] 
   [INFO] Results:
   [INFO] 
   [ERROR] Failures: 
   [ERROR]   StreamingSegmentManagerTest.testAddEventAndScan:120 expected:<80000> but was:<30007>
   [ERROR]   StreamingSegmentManagerTest.testIndexFilter:182 expected:<153298[080]0000> but was:<153298[104]0000>
   [INFO] 
   [ERROR] Tests run: 29, Failures: 2, Errors: 0, Skipped: 0
   [INFO] 
   [INFO] 
   [INFO] ------------------------------------------------------------------------
   [INFO] Skipping Apache Kylin
   [INFO] This project has been banned from the build due to previous failures.
   [INFO] ------------------------------------------------------------------------
   [INFO] ------------------------------------------------------------------------
   [INFO] Reactor Summary:
   [INFO] 
   [INFO] Apache Kylin 3.1.1-SNAPSHOT ........................ SUCCESS [  3.516 s]
   [INFO] Apache Kylin - kylin External ...................... SUCCESS [  9.946 s]
   [INFO] Apache Kylin - Core Common ......................... SUCCESS [ 22.354 s]
   [INFO] Apache Kylin - Core Metadata ....................... SUCCESS [ 48.745 s]
   [INFO] Apache Kylin - Core Dictionary ..................... SUCCESS [03:16 min]
   [INFO] Apache Kylin - Core Cube ........................... SUCCESS [02:19 min]
   [INFO] Apache Kylin - Core Metrics ........................ SUCCESS [  5.364 s]
   [INFO] Apache Kylin - Core Job ............................ SUCCESS [01:08 min]
   [INFO] Apache Kylin - Core Storage ........................ SUCCESS [  9.280 s]
   [INFO] Apache Kylin - Stream Core ......................... FAILURE [01:02 min]
   [INFO] Apache Kylin - MapReduce Engine .................... SKIPPED
   [INFO] Apache Kylin - Spark Engine ........................ SKIPPED
   [INFO] Apache Kylin - Flink Engine ........................ SKIPPED
   [INFO] Apache Kylin - Hive Source ......................... SKIPPED
   [INFO] Apache Kylin - DataSource SDK ...................... SKIPPED
   [INFO] Apache Kylin - Jdbc Source ......................... SKIPPED
   [INFO] Apache Kylin - Kafka Source ........................ SKIPPED
   [INFO] Apache Kylin - Cache ............................... SKIPPED
   [INFO] Apache Kylin - HBase Storage ....................... SKIPPED
   [INFO] Apache Kylin - Query ............................... SKIPPED
   [INFO] Apache Kylin - Metrics Reporter Hive ............... SKIPPED
   [INFO] Apache Kylin - Metrics Reporter Kafka .............. SKIPPED
   [INFO] Apache Kylin - Stream Source Kafka ................. SKIPPED
   [INFO] Apache Kylin - Stream Coordinator .................. SKIPPED
   [INFO] Apache Kylin - Stream Receiver ..................... SKIPPED
   [INFO] Apache Kylin - Stream Storage ...................... SKIPPED
   [INFO] Apache Kylin - REST Server Base .................... SKIPPED
   [INFO] Apache Kylin - Tool ................................ SKIPPED
   [INFO] Apache Kylin - Cube Migration Service .............. SKIPPED
   [INFO] Apache Kylin - REST Server ......................... SKIPPED
   [INFO] Apache Kylin - JDBC Driver ......................... SKIPPED
   [INFO] Apache Kylin - Assembly ............................ SKIPPED
   [INFO] Apache Kylin - Tool Assembly ....................... SKIPPED
   [INFO] Apache Kylin - Integration Test .................... SKIPPED
   [INFO] Apache Kylin - Tomcat Extension 3.1.1-SNAPSHOT ..... SKIPPED
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD FAILURE
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time: 09:28 min
   [INFO] Finished at: 2020-10-09T11:27:28Z
   [INFO] ------------------------------------------------------------------------
   [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on project kylin-stream-core: There are test failures.
   [ERROR] 
   [ERROR] Please refer to /home/travis/build/apache/kylin/stream-core/../target/surefire-reports for the individual test results.
   [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream.
   [ERROR] -> [Help 1]
   org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on project kylin-stream-core: There are test failures.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] ggKe commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

Posted by GitBox <gi...@apache.org>.
ggKe commented on pull request #1438:
URL: https://github.com/apache/kylin/pull/1438#issuecomment-706120407


   This modification is currently working well in our work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] ggKe commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

Posted by GitBox <gi...@apache.org>.
ggKe commented on pull request #1438:
URL: https://github.com/apache/kylin/pull/1438#issuecomment-706120407


   This modification is currently working well in our work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] coveralls commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1438:
URL: https://github.com/apache/kylin/pull/1438#issuecomment-706548304


   ## Pull Request Test Coverage Report for [Build 6440](https://coveralls.io/builds/34077445)
   
   * **3** of **7**   **(42.86%)**  changed or added relevant lines in **1** file are covered.
   * **255** unchanged lines in **12** files lost coverage.
   * Overall coverage decreased (**-0.0006%**) to **28.05%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/query/MultiThreadsResultCollector.java](https://coveralls.io/builds/34077445/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fquery%2FMultiThreadsResultCollector.java#L92) | 3 | 7 | 42.86%
   <!-- | **Total:** | **3** | **7** | **42.86%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/34077445/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
   | [server-base/src/main/java/org/apache/kylin/rest/security/KylinUserManager.java](https://coveralls.io/builds/34077445/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinUserManager.java#L144) | 1 | 0% |
   | [tool/src/main/java/org/apache/kylin/tool/query/ProbabilityGenerator.java](https://coveralls.io/builds/34077445/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fquery%2FProbabilityGenerator.java#L42) | 1 | 81.58% |
   | [core-common/src/main/java/org/apache/kylin/common/util/ServerMode.java](https://coveralls.io/builds/34077445/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FServerMode.java#L71) | 3 | 0% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserService.java](https://coveralls.io/builds/34077445/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserService.java#L219) | 7 | 0% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserGroupService.java](https://coveralls.io/builds/34077445/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserGroupService.java#L159) | 9 | 0% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/34077445/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L67) | 13 | 79.07% |
   | [server-base/src/main/java/org/apache/kylin/rest/security/KylinAuthenticationProvider.java](https://coveralls.io/builds/34077445/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FKylinAuthenticationProvider.java#L56) | 30 | 0% |
   | [server-base/src/main/java/org/apache/kylin/rest/controller/UserController.java](https://coveralls.io/builds/34077445/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FUserController.java#L223) | 34 | 0% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/34077445/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L152) | 45 | 0% |
   <!-- | **Total:** | **255** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/34077445/badge)](https://coveralls.io/builds/34077445) |
   | :-- | --: |
   | Change from base [Build 6416](https://coveralls.io/builds/33804340): |  -0.0006% |
   | Covered Lines: | 26256 |
   | Relevant Lines: | 93604 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus commented on pull request #1438: KYLIN-4771 Clear the recordCachePool when the deadline has reached

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1438:
URL: https://github.com/apache/kylin/pull/1438#issuecomment-706552419


   Thank you, that's great.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org