You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/02/11 04:06:21 UTC

[GitHub] [storm] Ethanlm opened a new pull request #3208: [STORM-3579] use the topo conf for thrift client in Worker code

Ethanlm opened a new pull request #3208: [STORM-3579]  use the topo conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208
 
 
   Explained in the Jira: https://issues.apache.org/jira/browse/STORM-3579
   
   The problem here (and other places as well) is it's not using the correct config (daemon conf vs topology conf). 
   
   `worker.childopts` and `topology.worker.childopts` are JVM parameters used to launch workers. Users can supply their own `java.security.auth.login.config` to the worker. And it should be used for the thrift client used by the worker. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm commented on a change in pull request #3208: [STORM-3579] use the topo conf for thrift client in Worker code

Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3208: [STORM-3579]  use the topo conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208#discussion_r378393664
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
 ##########
 @@ -106,9 +105,9 @@
      * @param port           - port on which the worker runs
      * @param workerId       - worker id
      */
-
     public Worker(Map<String, Object> conf, IContext context, String topologyId, String assignmentId,
 
 Review comment:
   That would be great. Will do it (or some can do it) in the future if come across this code again. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm merged pull request #3208: [STORM-3579] use the topo conf for thrift client in Worker code

Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3208: [STORM-3579]  use the topo conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] Ethanlm commented on a change in pull request #3208: [STORM-3579] use the topo conf for thrift client in Worker code

Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3208: [STORM-3579]  use the topo conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208#discussion_r378392648
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
 ##########
 @@ -443,7 +451,7 @@ private void heartbeatToMasterIfLocalbeatFail(LSWorkerHeartbeat lsWorkerHeartbea
         } catch (Exception tr1) {
             //If any error/exception thrown, report directly to nimbus.
             LOG.warn("Exception when send heartbeat to local supervisor", tr1.getMessage());
-            try (NimbusClient nimbusClient = NimbusClient.getConfiguredClient(conf)) {
+            try (NimbusClient nimbusClient = NimbusClient.getConfiguredClient(topologyConf)) {
 
 Review comment:
   NimbusClient does not need a topoConf strictly. If it's used on supervisor, it will be a supervisor conf.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] agresch commented on a change in pull request #3208: [STORM-3579] use the topo conf for thrift client in Worker code

Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3208: [STORM-3579]  use the topo conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208#discussion_r377674522
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
 ##########
 @@ -443,7 +451,7 @@ private void heartbeatToMasterIfLocalbeatFail(LSWorkerHeartbeat lsWorkerHeartbea
         } catch (Exception tr1) {
             //If any error/exception thrown, report directly to nimbus.
             LOG.warn("Exception when send heartbeat to local supervisor", tr1.getMessage());
-            try (NimbusClient nimbusClient = NimbusClient.getConfiguredClient(conf)) {
+            try (NimbusClient nimbusClient = NimbusClient.getConfiguredClient(topologyConf)) {
 
 Review comment:
   Can you update the javadoc for NimbusClient.getConfiguredClient() to indicate it needs a topoconf?
   
   Are there any other uses of NimbusClient.getConfiguredClient() that need fixing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [storm] agresch commented on a change in pull request #3208: [STORM-3579] use the topo conf for thrift client in Worker code

Posted by GitBox <gi...@apache.org>.
agresch commented on a change in pull request #3208: [STORM-3579]  use the topo conf for thrift client in Worker code
URL: https://github.com/apache/storm/pull/3208#discussion_r377672392
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
 ##########
 @@ -106,9 +105,9 @@
      * @param port           - port on which the worker runs
      * @param workerId       - worker id
      */
-
     public Worker(Map<String, Object> conf, IContext context, String topologyId, String assignmentId,
 
 Review comment:
   can we update the javadoc that this is a supervisor conf?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services