You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/25 06:07:17 UTC

[GitHub] [flink] dianfu opened a new pull request #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

dianfu opened a new pull request #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206
 
 
   
   ## What is the purpose of the change
   
   *This pull request sets io.netty.tryReflectionSetAccessible to true for JDK9+. See https://issues.apache.org/jira/browse/ARROW-5412 for more details.*
   
   
   ## Brief change log
   
     - *Adds `-Dio.netty.tryReflectionSetAccessible=true` option to the flink-python unit tests*
   
   ## Verifying this change
   
   Tests manually in my local environment.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590713510
 
 
   @hequn8128  Thanks for the review and suggestion. I'm in favor of making it transparent for users, for example, setting this environment variable in the open method of the Arrow operator to be introduced. I will check if this is possible in the Arrow operator PR. If not, we can add a documentation for users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 edited a comment on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
hequn8128 edited a comment on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590715955
 
 
   @dianfu Solve this automatically is good. FYI, ([ARROW-7223](https://issues.apache.org/jira/browse/ARROW-7223)), It seems setting the property won't help, as it's read at static initialization time. I have created a jira([FLINK-16273](https://issues.apache.org/jira/browse/FLINK-16273)) for addressing this problem for users.
   
   I will merge this once Travis passed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590726707
 
 
   @hequn8128 Thanks for creating the following-up ticket.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590703317
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150424316",
       "triggerID" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b6b8bbaf1be639dae03850e547721a293037d9c8 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150424316) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590701000
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 127112aace5b390ec54d4fe6c1c1dde3a0eea666 (Tue Feb 25 06:08:56 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 merged pull request #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590703317
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150424316",
       "triggerID" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "triggerType" : "PUSH"
     }, {
       "hash" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5544",
       "triggerID" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b6b8bbaf1be639dae03850e547721a293037d9c8 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150424316) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5544) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590703317
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b6b8bbaf1be639dae03850e547721a293037d9c8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b6b8bbaf1be639dae03850e547721a293037d9c8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #11206: [FLINK-16263][python][tests] Set io.netty.tryReflectionSetAccessible to true for JDK9+
URL: https://github.com/apache/flink/pull/11206#issuecomment-590715955
 
 
   @dianfu Solve this automatically is good. FYI, ([ARROW-7223](https://issues.apache.org/jira/browse/ARROW-7223)), It seems setting the property won't help, as it's read at static initialization time.
   
   Anyway, maybe we can create another jira for this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services