You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2025/04/14 04:08:46 UTC
[PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
xinyiZzz opened a new pull request, #50017:
URL: https://github.com/apache/doris/pull/50017
### What problem does this PR solve?
Fix 1
```
read.F20250412 04:16:47.972313 198085 thread_context.h:204] Check failed: is_attach_task()
9# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be
10# Allocator<false, false, false, DefaultMemoryAllocator>::sys_memory_check(unsigned long) const at /home/zcp/repo_center/doris_master/doris/be/src/vec/common/allocator.cpp:191
11# Allocator<false, false, false, DefaultMemoryAllocator>::alloc_impl(unsigned long, unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/vec/common/allocator.h:254
12# doris::io::Memory<Allocator<false, false, false, DefaultMemoryAllocator> >::Memory(unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.cpp:48
13# doris::io::FileBuffer::FileBuffer(doris::io::BufferType, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()>, unsigned long, doris::io::OperationState) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.cpp:86
14# doris::io::UploadFileBuffer::UploadFileBuffer(std::function<void (doris::io::UploadFileBuffer&)>, doris::io::OperationState, unsigned long, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()>) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.h:157
15# decltype (::new ((void*)(0)) doris::io::UploadFileBuffer(std::declval<std::function<void (doris::io::UploadFileBuffer&)> >(), std::declval<doris::io::OperationState>(), std::declval<unsigned long&>(), std::declval<std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()> >())) std::construct_at<doris::io::UploadFileBuffer, std::function<void (doris::io::UploadFileBuffer&)>, doris::io::OperationState, unsigned long&, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()> >(doris::io::UploadFileBuffer*, std::function<void (doris::io::UploadFileBuffer&)>&&, doris::io::OperationState&&, unsigned long&, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()>&&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_construct.h:97
16# doris::io::FileBufferBuilder::build(std::shared_ptr<doris::io::FileBuffer>*) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.cpp:247
17# doris::io::S3FileWriter::_build_upload_buffer() at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_writer.cpp:199
18# doris::io::S3FileWriter::_close_impl() at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_writer.cpp:215
19# doris::io::S3FileWriter::close(bool) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_writer.cpp:156
20# doris::vectorized::ParquetOutputStream::Close() at /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vparquet_transformer.cpp:85
21# doris::vectorized::ParquetOutputStream::~ParquetOutputStream() at /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vparquet_transformer.cpp:58
22# doris::vectorized::ParquetOutputStream::~ParquetOutputStream() at /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vparquet_transformer.cpp:56
23# doris::vectorized::VParquetTransformer::~VParquetTransformer() at /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vparquet_transformer.h:110
24# doris::vectorized::VParquetTransformer::~VParquetTransformer() at /home/zcp/repo_center/doris_master/doris/be/src/vec/runtime/vparquet_transformer.h:110
25# doris::vectorized::VFileResultWriter::~VFileResultWriter() at /home/zcp/repo_center/doris_master/doris/be/src/vec/sink/writer/vfile_result_writer.h:56
26# doris::pipeline::AsyncWriterSink<doris::vectorized::VFileResultWriter, doris::pipeline::ResultFileSinkOperatorX>::~AsyncWriterSink() at /home/zcp/repo_center/doris_master/doris/be/src/pipeline/exec/operator.h:1059
27# doris::pipeline::ResultFileSinkLocalState::~ResultFileSinkLocalState() at /home/zcp/repo_center/doris_master/doris/be/src/pipeline/exec/result_file_sink_operator.cpp:57
28# doris::RuntimeState::~RuntimeState() at /home/zcp/repo_center/doris_master/doris/be/src/runtime/runtime_state.cpp:211
29# doris::pipeline::PipelineFragmentContext::~PipelineFragmentContext() at /home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_fragment_context.cpp:149
30# std::_Function_handler<void (), doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0>::_M_invoke(std::_Any_data const&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
```
Fix 2:
```
F20250411 00:00:31.856455 173889 thread_context.h:204] Check failed: is_attach_task()
9# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/PERFORMANCE_ENV/be/lib/doris_be
10# Allocator<false, false, false, DefaultMemoryAllocator>::sys_memory_check(unsigned long) const at /home/zcp/repo_center/doris_master/doris/be/src/vec/common/allocator.cpp:191
11# Allocator<false, false, false, DefaultMemoryAllocator>::alloc_impl(unsigned long, unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/vec/common/allocator.h:254
12# doris::io::Memory<Allocator<false, false, false, DefaultMemoryAllocator> >::Memory(unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.cpp:48
13# doris::io::FileBuffer::FileBuffer(doris::io::BufferType, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()>, unsigned long, doris::io::OperationState) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.cpp:86
14# doris::io::UploadFileBuffer::UploadFileBuffer(std::function<void (doris::io::UploadFileBuffer&)>, doris::io::OperationState, unsigned long, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()>) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.h:157
15# decltype (::new ((void*)(0)) doris::io::UploadFileBuffer(std::declval<std::function<void (doris::io::UploadFileBuffer&)> >(), std::declval<doris::io::OperationState>(), std::declval<unsigned long&>(), std::declval<std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()> >())) std::construct_at<doris::io::UploadFileBuffer, std::function<void (doris::io::UploadFileBuffer&)>, doris::io::OperationState, unsigned long&, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()> >(doris::io::UploadFileBuffer*, std::function<void (doris::io::UploadFileBuffer&)>&&, doris::io::OperationState&&, unsigned long&, std::function<std::unique_ptr<doris::io::FileBlocksHolder, std::default_delete<doris::io::FileBlocksHolder> > ()>&&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_construct.h:97
16# doris::io::FileBufferBuilder::build(std::shared_ptr<doris::io::FileBuffer>*) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_bufferpool.cpp:247
17# doris::io::S3FileWriter::_build_upload_buffer() at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_writer.cpp:199
18# doris::io::S3FileWriter::appendv(doris::Slice const*, unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/io/fs/s3_file_writer.cpp:251
19# std::enable_if<is_invocable_r_v<doris::Status, doris::io::S3FileSystem::batch_upload_impl(std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&, std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&)::$_0&, unsigned long>, doris::Status>::type std::__invoke_r<doris::Status, doris::io::S3FileSystem::batch_upload_impl(std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&, std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&)::$_0&, unsigned long>(doris::io::S3FileSystem::batch_upload_impl(std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&, std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&)::$_0&, unsigned long&&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/1
1/bits/invoke.h:114
20# std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<doris::Status>, std::__future_base::_Result_base::_Deleter>, std::__future_base::_Task_state<doris::io::S3FileSystem::batch_upload_impl(std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&, std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&)::$_0, std::allocator<int>, doris::Status (unsigned long)>::_M_run(unsigned long&&)::{lambda()#1}, doris::Status> >::_M_invoke(std::_Any_data const&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
21# std::__future_base::_State_baseV2::_M_do_set(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/future:575
22# __pthread_once_slow at ./nptl/pthread_once.c:118
23# std::__future_base::_State_baseV2::_M_set_result(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>, bool) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/future:411
24# std::__future_base::_Task_state<doris::io::S3FileSystem::batch_upload_impl(std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&, std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&)::$_0, std::allocator<int>, doris::Status (unsigned long)>::_M_run(unsigned long&&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/future:1447
25# std::_Function_handler<void (), doris::io::S3FileSystem::batch_upload_impl(std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&, std::vector<std::filesystem::__cxx11::path, std::allocator<std::filesystem::__cxx11::path> > const&)::$_1>::_M_invoke(std::_Any_data const&) at /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
```
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2804227912
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2800487556
<details>
<summary>ClickBench: <b>Total hot run time: 31.45 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c9da497dcd30f08386d29a52c2969baacd14a834, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.10 0.12
query3 0.26 0.19 0.19
query4 1.59 0.20 0.20
query5 0.62 0.58 0.60
query6 1.18 0.71 0.72
query7 0.03 0.02 0.02
query8 0.04 0.03 0.04
query9 0.56 0.52 0.51
query10 0.56 0.57 0.57
query11 0.16 0.10 0.10
query12 0.15 0.12 0.11
query13 0.61 0.60 0.60
query14 2.79 2.69 2.83
query15 0.92 0.86 0.85
query16 0.40 0.37 0.39
query17 1.02 1.02 1.02
query18 0.20 0.20 0.20
query19 1.93 1.93 1.78
query20 0.01 0.01 0.01
query21 15.36 0.94 0.55
query22 0.74 1.26 0.66
query23 14.85 1.40 0.60
query24 7.12 1.66 1.04
query25 0.52 0.20 0.14
query26 0.49 0.17 0.15
query27 0.05 0.05 0.05
query28 10.46 0.85 0.43
query29 12.61 3.92 3.30
query30 0.25 0.08 0.06
query31 2.82 0.58 0.39
query32 3.24 0.56 0.47
query33 2.98 3.12 3.06
query34 15.79 5.14 4.55
query35 4.58 4.54 4.53
query36 0.68 0.50 0.49
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.02 0.03
query40 0.17 0.13 0.12
query41 0.08 0.03 0.02
query42 0.03 0.02 0.02
query43 0.04 0.03 0.03
Total cold run time: 106.21 s
Total hot run time: 31.45 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2804227616
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz merged PR #50017:
URL: https://github.com/apache/doris/pull/50017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2800423940
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2800481436
<details>
<summary>TPC-DS: <b>Total hot run time: 192807 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c9da497dcd30f08386d29a52c2969baacd14a834, data reload: false
query1 1406 1104 1038 1038
query2 6104 1852 1859 1852
query3 11146 4572 4568 4568
query4 53061 25448 23055 23055
query5 5023 539 463 463
query6 318 208 204 204
query7 4884 513 284 284
query8 313 254 248 248
query9 5295 2614 2589 2589
query10 425 329 270 270
query11 15036 15060 14739 14739
query12 161 111 107 107
query13 1036 520 405 405
query14 10151 6351 6576 6351
query15 195 206 180 180
query16 7132 664 491 491
query17 1097 746 605 605
query18 1632 416 330 330
query19 211 205 186 186
query20 124 123 129 123
query21 215 121 110 110
query22 4473 4390 4230 4230
query23 34083 33648 33632 33632
query24 6610 2438 2437 2437
query25 463 472 394 394
query26 733 277 153 153
query27 2351 502 351 351
query28 3450 2441 2419 2419
query29 569 562 421 421
query30 276 222 198 198
query31 856 865 809 809
query32 69 66 69 66
query33 466 356 324 324
query34 773 887 509 509
query35 813 844 774 774
query36 932 1018 909 909
query37 120 99 75 75
query38 4268 4263 4169 4169
query39 1484 1477 1448 1448
query40 227 127 105 105
query41 59 54 54 54
query42 134 119 112 112
query43 521 520 483 483
query44 1302 817 811 811
query45 186 200 170 170
query46 849 1026 649 649
query47 1830 1886 1786 1786
query48 375 426 306 306
query49 687 510 415 415
query50 670 689 401 401
query51 4263 4292 4315 4292
query52 106 107 103 103
query53 236 262 187 187
query54 592 575 507 507
query55 85 83 82 82
query56 292 283 296 283
query57 1163 1199 1123 1123
query58 267 259 275 259
query59 2636 2728 2628 2628
query60 343 320 322 320
query61 129 128 126 126
query62 730 730 673 673
query63 234 196 186 186
query64 1790 1027 756 756
query65 4309 4255 4257 4255
query66 715 402 298 298
query67 15841 15740 15140 15140
query68 7922 880 520 520
query69 531 298 267 267
query70 1209 1118 1038 1038
query71 495 303 295 295
query72 5906 4932 4843 4843
query73 1513 685 344 344
query74 9233 9194 8745 8745
query75 3850 3200 2688 2688
query76 4270 1198 743 743
query77 631 362 276 276
query78 10010 10215 9388 9388
query79 2256 818 569 569
query80 628 510 435 435
query81 479 264 229 229
query82 465 132 95 95
query83 329 258 236 236
query84 291 111 97 97
query85 780 342 380 342
query86 387 315 271 271
query87 4439 4462 4408 4408
query88 3493 2180 2180 2180
query89 440 319 275 275
query90 1966 205 201 201
query91 139 148 107 107
query92 84 61 61 61
query93 1786 954 588 588
query94 672 405 368 368
query95 368 293 286 286
query96 484 559 268 268
query97 3125 3206 3128 3128
query98 219 209 210 209
query99 1437 1437 1281 1281
Total cold run time: 298162 ms
Total hot run time: 192807 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2800598679
# BE UT Coverage Report
Increment line coverage `0.00% (0/3)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/c9da497dcd30f08386d29a52c2969baacd14a834_c9da497dcd30f08386d29a52c2969baacd14a834/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/c9da497dcd30f08386d29a52c2969baacd14a834_c9da497dcd30f08386d29a52c2969baacd14a834/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.49% (14111/26883) |
| Line Coverage | 41.29% (122010/295479) |
| Region Coverage | 40.05% (62132/155146) |
| Branch Coverage | 34.69% (31103/89662) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2800423777
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](resource) Fix `S3FileWriter` thread attach task [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50017:
URL: https://github.com/apache/doris/pull/50017#issuecomment-2800467296
<details>
<summary>TPC-H: <b>Total hot run time: 34085 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c9da497dcd30f08386d29a52c2969baacd14a834, data reload: false
------ Round 1 ----------------------------------
q1 25739 4990 4997 4990
q2 2078 300 199 199
q3 10356 1220 688 688
q4 10222 1023 540 540
q5 7535 2312 2349 2312
q6 189 166 137 137
q7 908 743 610 610
q8 9314 1223 1070 1070
q9 6922 5108 5135 5108
q10 6868 2282 1891 1891
q11 472 280 277 277
q12 360 350 223 223
q13 17787 3609 3067 3067
q14 229 224 204 204
q15 536 476 484 476
q16 641 618 579 579
q17 602 851 381 381
q18 7598 7120 7184 7120
q19 1318 949 562 562
q20 334 336 231 231
q21 4483 3345 2456 2456
q22 1072 1008 964 964
Total cold run time: 115563 ms
Total hot run time: 34085 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5080 5100 5069 5069
q2 238 324 236 236
q3 2180 2619 2290 2290
q4 1402 1805 1391 1391
q5 4372 4401 4339 4339
q6 219 175 130 130
q7 1995 1904 1761 1761
q8 2594 2562 2743 2562
q9 7281 7379 7277 7277
q10 2978 3164 2769 2769
q11 584 510 495 495
q12 686 780 649 649
q13 3587 4044 3511 3511
q14 305 327 291 291
q15 534 472 478 472
q16 683 700 637 637
q17 1179 1539 1428 1428
q18 8007 7868 7467 7467
q19 767 742 748 742
q20 1916 1993 1970 1970
q21 5295 4838 4785 4785
q22 1098 1100 1005 1005
Total cold run time: 52980 ms
Total hot run time: 51276 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org