[GitHub] [incubator-superset] john-bodley commented on issue #7816: Add cache_key_wrapper to Jinja template processor

[GitBox <gi...@apache.org>]

john-bodley commented on issue #7816: Add cache_key_wrapper to Jinja template processor
URL: https://github.com/apache/incubator-superset/pull/7816#issuecomment-512914233
 
 
   @villebro I think this approach seems valid. My only question is it seems that `cache_key` takes a dictionary of extra cache key arguments whereas in your implementation you're using a single predefined key `extra_cache_keys` with a list of keys. I can understand why this is the case from your implementation but was wondering whether it's viable to use a dictionary. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org