You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/03/01 09:11:42 UTC

[GitHub] dima-asana opened a new pull request #4808: [AIRFLOW_3982] Update DagRun state based on its tasks rather than DAG's

dima-asana opened a new pull request #4808: [AIRFLOW_3982] Update DagRun state based on its tasks rather than DAG's
URL: https://github.com/apache/airflow/pull/4808
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3982
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   If a DagRun does not have the same tasks as its DAG (e.g. a task is added or removed later), it should update its state based on its tasks rather than the DAG's.
   
   This is probably mostly relevant when (a) adding a task to a DAG with a different start date and then (b) clearing a past DAG Run.
   
   Note that this CR also removes the adhoc task references.  The code path that led to this bug is attempting to exclude adhoc tasks, which don't exist anymore as of https://github.com/apache/airflow/pull/1667.  I've removed other references for consistency.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   SchedulerJobTest.test_dagrun_root_after_dagrun_unfinished
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services