You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Robert Metzger (JIRA)" <ji...@apache.org> on 2014/07/07 22:20:33 UTC
[jira] [Comment Edited] (FLINK-386) Duplicate dependencies in lib
folder
[ https://issues.apache.org/jira/browse/FLINK-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054160#comment-14054160 ]
Robert Metzger edited comment on FLINK-386 at 7/7/14 8:18 PM:
--------------------------------------------------------------
I really like that you removed some of our dependencies. That should help speeding up our tests.
I'm not so sure about just upgrading the versions of the dependencies. Ideally they contain bugfixes and improvements, but we need to test our system well after adding these changes.
Can you open a pull request from the depcleanup branch? Its much easier to review changes in a PR.
was (Author: rmetzger):
I really like that you removed some of our dependencies. That should help speeding up our tests.
I'm not so sure about just upgrading the versions of the dependencies. Sure, ideally they contain bugfixes and improvements, but we need to test our system well after adding these changes.
Can you open a pull request from the depcleanup branch? Its much easier to review changes in a PR.
> Duplicate dependencies in lib folder
> ------------------------------------
>
> Key: FLINK-386
> URL: https://issues.apache.org/jira/browse/FLINK-386
> Project: Flink
> Issue Type: Bug
> Reporter: GitHub Import
> Assignee: Daniel Warneke
> Labels: github-import
> Fix For: pre-apache
>
>
> There are some dependencies for which two different versions end up in the lib folder
> ```
> servlet-api-2.5-6.1.14.jar
> servlet-api-3.0.20100224.jar
> stax-api-1.0.1.jar
> stax-api-1.0-2.jar
> ```
> As far as I see it, these are transitive dependencies.
> Teh problem is that what classes are available at runtime depends on which jar is loaded first by the classloader. This is somewhat unpredictable and can lead to weird errors in the components that have these dependencies.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/386
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels:
> Created at: Thu Jan 09 19:44:07 CET 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.2#6252)