You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Pierre Smits <pi...@apache.org> on 2022/01/13 09:24:38 UTC

Re: [ofbiz-framework] branch release22.01 updated: Fixed: no functional change, right version (22.01) in gradle.yaml

Hey Jacques,

The change states:

+    branches: [ release20.01 ]


Should it not be:

+    branches: [ release22.01 ]



Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Thu, Jan 13, 2022 at 10:14 AM <jl...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> jleroux pushed a commit to branch release22.01
> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>
>
> The following commit(s) were added to refs/heads/release22.01 by this push:
>      new a114a20  Fixed: no functional change, right version (22.01) in
> gradle.yaml
> a114a20 is described below
>
> commit a114a20ba8e368e4db53295784ae631427a71ffd
> Author: Jacques Le Roux <ja...@les7arts.com>
> AuthorDate: Thu Jan 13 10:14:05 2022 +0100
>
>     Fixed: no functional change, right version (22.01) in gradle.yaml
>
>     This will also allow to test the just updated BB config, nothing
> happened last
>     time no ideas why yet...
> ---
>  .github/workflows/gradle.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.github/workflows/gradle.yaml b/.github/workflows/gradle.yaml
> index 18d5c18..0201056 100644
> --- a/.github/workflows/gradle.yaml
> +++ b/.github/workflows/gradle.yaml
> @@ -21,9 +21,9 @@ name: Java CI with Gradle
>
>  on:
>    push:
> -    branches: [ trunk ]
> +    branches: [ release20.01 ]
>    pull_request:
> -    branches: [ trunk ]
> +    branches: [ release20.01 ]
>
>  jobs:
>    build:
>

Re: [ofbiz-framework] branch release22.01 updated: Fixed: no functional change, right version (22.01) in gradle.yaml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 13/01/2022 à 12:06, Pierre Smits a écrit :
> Github documentation regarding actions/workflow indicates that it should
> be.

This is what I was asking, could you please provide a link?

TIA

Jacques

> How would I check? I don't have the privileges.
>
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
> 2008 (without privileges)
> Proud contributor to the ASF since 2006
>
> *Apache Directory <https://directory.apache.org>, PMC Member*
>
>
> On Thu, Jan 13, 2022 at 11:41 AM Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Le 13/01/2022 à 10:58, Pierre Smits a écrit :
>>> If the script is the same for every branch in maintenance, why not make
>> the
>>> script generic like:
>>>
>>> branches: *
>> I'm unsure it's possible, did you check?
>>
>> Jacques
>>
>>

Re: [ofbiz-framework] branch release22.01 updated: Fixed: no functional change, right version (22.01) in gradle.yaml

Posted by Pierre Smits <pi...@apache.org>.
Github documentation regarding actions/workflow indicates that it should
be.
How would I check? I don't have the privileges.


Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Thu, Jan 13, 2022 at 11:41 AM Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Le 13/01/2022 à 10:58, Pierre Smits a écrit :
> > If the script is the same for every branch in maintenance, why not make
> the
> > script generic like:
> >
> > branches: *
> I'm unsure it's possible, did you check?
>
> Jacques
>
>

Re: [ofbiz-framework] branch release22.01 updated: Fixed: no functional change, right version (22.01) in gradle.yaml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 13/01/2022 à 10:58, Pierre Smits a écrit :
> If the script is the same for every branch in maintenance, why not make the
> script generic like:
>
> branches: *
I'm unsure it's possible, did you check?

Jacques


Re: [ofbiz-framework] branch release22.01 updated: Fixed: no functional change, right version (22.01) in gradle.yaml

Posted by Pierre Smits <pi...@apache.org>.
Hi Jacques,

No worries. That is what collaborating in an open source project is about.

If the script is the same for every branch in maintenance, why not make the
script generic like:

branches: *


Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)
Proud contributor to the ASF since 2006

*Apache Directory <https://directory.apache.org>, PMC Member*


On Thu, Jan 13, 2022 at 10:46 AM Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:

> Oops, right, thanks Pierre,
>
> I keep doing this error from start, not sure why. Several pairs of eyes
> always prove better!
>
> Jacques
>
> Le 13/01/2022 à 10:24, Pierre Smits a écrit :
> > Hey Jacques,
> >
> > The change states:
> >
> > +    branches: [ release20.01 ]
> >
> >
> > Should it not be:
> >
> > +    branches: [ release22.01 ]
> >
> >
> >
> > Met vriendelijke groet,
> >
> > Pierre Smits
> > *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/>
> since
> > 2008 (without privileges)
> > Proud contributor to the ASF since 2006
> >
> > *Apache Directory <https://directory.apache.org>, PMC Member*
> >
> >
> > On Thu, Jan 13, 2022 at 10:14 AM <jl...@apache.org> wrote:
> >
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> jleroux pushed a commit to branch release22.01
> >> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/release22.01 by this
> push:
> >>       new a114a20  Fixed: no functional change, right version (22.01) in
> >> gradle.yaml
> >> a114a20 is described below
> >>
> >> commit a114a20ba8e368e4db53295784ae631427a71ffd
> >> Author: Jacques Le Roux <ja...@les7arts.com>
> >> AuthorDate: Thu Jan 13 10:14:05 2022 +0100
> >>
> >>      Fixed: no functional change, right version (22.01) in gradle.yaml
> >>
> >>      This will also allow to test the just updated BB config, nothing
> >> happened last
> >>      time no ideas why yet...
> >> ---
> >>   .github/workflows/gradle.yaml | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/.github/workflows/gradle.yaml
> b/.github/workflows/gradle.yaml
> >> index 18d5c18..0201056 100644
> >> --- a/.github/workflows/gradle.yaml
> >> +++ b/.github/workflows/gradle.yaml
> >> @@ -21,9 +21,9 @@ name: Java CI with Gradle
> >>
> >>   on:
> >>     push:
> >> -    branches: [ trunk ]
> >> +    branches: [ release20.01 ]
> >>     pull_request:
> >> -    branches: [ trunk ]
> >> +    branches: [ release20.01 ]
> >>
> >>   jobs:
> >>     build:
> >>
>

Re: [ofbiz-framework] branch release22.01 updated: Fixed: no functional change, right version (22.01) in gradle.yaml

Posted by Jacques Le Roux <ja...@les7arts.com>.
Oops, right, thanks Pierre,

I keep doing this error from start, not sure why. Several pairs of eyes always prove better!

Jacques

Le 13/01/2022 à 10:24, Pierre Smits a écrit :
> Hey Jacques,
>
> The change states:
>
> +    branches: [ release20.01 ]
>
>
> Should it not be:
>
> +    branches: [ release22.01 ]
>
>
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
> 2008 (without privileges)
> Proud contributor to the ASF since 2006
>
> *Apache Directory <https://directory.apache.org>, PMC Member*
>
>
> On Thu, Jan 13, 2022 at 10:14 AM <jl...@apache.org> wrote:
>
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> jleroux pushed a commit to branch release22.01
>> in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
>>
>>
>> The following commit(s) were added to refs/heads/release22.01 by this push:
>>       new a114a20  Fixed: no functional change, right version (22.01) in
>> gradle.yaml
>> a114a20 is described below
>>
>> commit a114a20ba8e368e4db53295784ae631427a71ffd
>> Author: Jacques Le Roux <ja...@les7arts.com>
>> AuthorDate: Thu Jan 13 10:14:05 2022 +0100
>>
>>      Fixed: no functional change, right version (22.01) in gradle.yaml
>>
>>      This will also allow to test the just updated BB config, nothing
>> happened last
>>      time no ideas why yet...
>> ---
>>   .github/workflows/gradle.yaml | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.github/workflows/gradle.yaml b/.github/workflows/gradle.yaml
>> index 18d5c18..0201056 100644
>> --- a/.github/workflows/gradle.yaml
>> +++ b/.github/workflows/gradle.yaml
>> @@ -21,9 +21,9 @@ name: Java CI with Gradle
>>
>>   on:
>>     push:
>> -    branches: [ trunk ]
>> +    branches: [ release20.01 ]
>>     pull_request:
>> -    branches: [ trunk ]
>> +    branches: [ release20.01 ]
>>
>>   jobs:
>>     build:
>>