You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/02 22:51:09 UTC

[GitHub] gigasquid opened a new pull request #11534: [MXNET-618] Clojure package - move NDArray and Symbol Code generation to Automatic

gigasquid opened a new pull request #11534: [MXNET-618] Clojure package - move NDArray and Symbol Code generation to Automatic
URL: https://github.com/apache/incubator-mxnet/pull/11534
 
 
   ## Description ##
    From feedback from the Clojure package PR https://github.com/apache/incubator-mxnet/pull/11205, this changes the automatic generation of the ndarray and symbol code from a manual step to an automatic compile-time (AOT) step. The generated code is no longer checked into git as well.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x ] All changes have test coverage:
   - [ x] Code is well-documented: 
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - Move ndarray and symbol code generation to compile time
   - Remove generated code files from git
   - Remove the alias to generate-code from the project file since it is now automatic
   
   ## Testing
   To test this change:
   
   1) Make sure there are no files in the `src/org/apache/clojure_mxnet/gen` directory
   2) Run `lein test`
   3) Tests should run fine and the generated files should be present in `src/org/apache/clojure_mxnet/gen` but ignored by git
   
   1) Make sure there are no files in the `src/org/apache/clojure_mxnet/gen` directory
   2) Run `lein install` to create target jar
   3) cd `examples/imclassification`
   4) run `lein run` to run the example with the installed jar
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services