You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/13 08:02:07 UTC
[GitHub] [commons-csv] dota17 opened a new pull request #69: Change JiraCsv164Test to JiraCsv154Test
dota17 opened a new pull request #69:
URL: https://github.com/apache/commons-csv/pull/69
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls commented on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-625732159
[](https://coveralls.io/builds/30647986)
Coverage remained the same at 98.507% when pulling **4c250b6d116cb344428ab1ac70e8c814da51db8a on dota17:JiraCsv154** into **57c77341d42f54b71018931dd4f389d507a30a3c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory merged pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
garydgregory merged pull request #69:
URL: https://github.com/apache/commons-csv/pull/69
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory edited a comment on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-643616044
@dota17 Please stop creating PRs while leaving the description field empty. Reviewed should not have to parse out your changes to try and understand why a PR is needed. In this specific case, the description should state _why_ you are making this change: Has the test code's purpose changed? Was it never called the right name in the first place? Or, was the Jira ticket itself changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls edited a comment on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-625732159
[](https://coveralls.io/builds/31431334)
Coverage decreased (-0.001%) to 98.506% when pulling **4c250b6d116cb344428ab1ac70e8c814da51db8a on dota17:JiraCsv154** into **57c77341d42f54b71018931dd4f389d507a30a3c on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] dota17 closed pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
dota17 closed pull request #69:
URL: https://github.com/apache/commons-csv/pull/69
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] coveralls edited a comment on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-625732159
[](https://coveralls.io/builds/31431469)
Coverage remained the same at 98.506% when pulling **26c543be04bd18e311c0b18b745e19b80ea4c6f7 on dota17:JiraCsv154** into **9b3046e6d9e0923202160055f4ab197e630ba1c4 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] dota17 commented on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
dota17 commented on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-643859014
@garydgregory
Oh sorry, I will pay attention on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] dota17 commented on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
dota17 commented on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-643588885
The content of this file is the test case of CSV-154. So the name should be modified to JiraCsv154Test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-643616044
@dota17 Please stop creating PRs while leaving the description field empty. Reviewed should not have to parse out your changes to try and understand why a PR is needed. In this specific case, the description should state _why_ you are making this change? Has the test code's purpose changed? Was it never called the right name in the first place? Or, was the Jira ticket itself changed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #69: Change JiraCsv164Test to JiraCsv154Test
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #69:
URL: https://github.com/apache/commons-csv/pull/69#issuecomment-643682732
> The content of this file is the test case of CSV-154. So the name should be modified to JiraCsv154Test.
Then say that in the description!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org