[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#discussion_r741984270



##########
File path: tools/qdstat
##########
@@ -743,10 +743,7 @@ class BusManager(object):
             row.append(PlainNum(t.batchesRebalancedToGlobal))
             rows.append(row)
             pooled_total += (t.typeSize * t.totalAllocFromHeap)
-        if not rows:

Review comment:
       You might want to leave this check since qdstat may be used against older routers that were built without enabling memory stats.
   
   Highly unlikely I would imagine, but who knows?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org