[GitHub] qpid-proton-j issue #15: PROTON-1916: Makes StringsBenchmark::encodeStringMe...

[gemmellr <gi...@git.apache.org>]

Github user gemmellr commented on the issue:

    https://github.com/apache/qpid-proton-j/pull/15
  
    The JIRA, PR, and commit say they are primarily changing the benchmark/test but most of the change has nothing to do with that. Even though the perf change is tiny and most things wont see it (due to them implementing their own WritableBuffer and not using the method updated at all) its really the main change here so things should reflect that.
    
    The benchmark updated was doing what was originally desired, but the updated version is more specifically targeting the String encoding side of things, so no issue with changing that. The commenting-out of the decode benchmark however seems like it should be removed though.
    
    The main updates change the bracing style of half the class, making it a lot harder to see what you actually changed than it needs to be, and then becoming inconsistent with the rest of the class. Please restore things to the existing format to minimise the diff.
    
    You have introduced a full new method that nothing apparently ever uses, since a non-array buffer isn't passed to it. I suppose there was a line untested before for this to be the case, but it was far simpler and there would now be a 50 line method in addition, so I think adding some basic testing is needed for that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org