You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/26 09:27:10 UTC
[GitHub] [fineract] vorburger opened a new pull request #782: add Policy re. unstable tests to README
vorburger opened a new pull request #782:
URL: https://github.com/apache/fineract/pull/782
@awasum OK for you?
@nikpawar89 makes sense?
@xurror @maektwain @fynmanoj @thesmallstar @DBryzz @wkk91193 @nemux @nnatarajan FYI!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nikpawar89 commented on pull request #782: add Policy re. unstable tests to README
Posted by GitBox <gi...@apache.org>.
nikpawar89 commented on pull request #782:
URL: https://github.com/apache/fineract/pull/782#issuecomment-619564550
+1 from me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #782: add Policy re. unstable tests to README
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #782:
URL: https://github.com/apache/fineract/pull/782#issuecomment-619522254
Why is the other Travis PR test failing?
I see this:
```org.apache.fineract.integrationtests.AccountingScenarioIntegrationTest > checkPeriodicAccrualAccountingFlow FAILED
java.lang.AssertionError at AccountingScenarioIntegrationTest.java:588```
Is this a flaky test? Something must be broken somewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #782: add Policy re. unstable tests to README
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #782:
URL: https://github.com/apache/fineract/pull/782#issuecomment-619565757
I've exceptionally self merged this README only change PR based on the 2 votes of support expressed by @xurror and @nikpawar, because I have too much gray hear to re-re-base it following the successful build and merge of #785 and then wait for it to build and turn green...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #782: add Policy re. unstable tests to README
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #782:
URL: https://github.com/apache/fineract/pull/782#issuecomment-619519020
The latest "force push" just now just added `@Ignore // TODO FINERACT-123` and _Of course, we very much appreciate you then jumping onto any such bugs and helping us figure out how to fix all ignored tests!_.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #782: add Policy re. unstable tests to README
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #782:
URL: https://github.com/apache/fineract/pull/782#issuecomment-619564468
> > I suggest that instead of having all this details stated out in one big paragraph, wouldn't it be better if the instructions were listed out in points form?. Reading a huge paragraph is kind of tedious and difficult to track. I have no problem with it though. Just think it would look better that way
>
> That is an excellent point, you are absolutely right, it was a bit "dense"... how about how it's now - better?
Yeah, definitely. That looks more like it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #782: add Policy re. unstable tests to README
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #782:
URL: https://github.com/apache/fineract/pull/782#issuecomment-619562813
> I suggest that instead of having all this details stated out in one big paragraph, wouldn't it be better if the instructions were listed out in points form?. Reading a huge paragraph is kind of tedious and difficult to track. I have no problem with it though. Just think it would look better that way
That is an excellent point, you are absolutely right, it was a bit "dense"... how about how it's now - better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org