You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/11 03:17:20 UTC
[GitHub] [apisix-helm-chart] fengxsong opened a new pull request, #369: feat support for configuring priority class name
fengxsong opened a new pull request, #369:
URL: https://github.com/apache/apisix-helm-chart/pull/369
1. fix securityContext setting for apisix workload;
2. support for configuring priorities to avoid preemption when cluster resources are tight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #369: feat support for configuring priority class name
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #369:
URL: https://github.com/apache/apisix-helm-chart/pull/369#discussion_r992096605
##########
charts/apisix-dashboard/README.md:
##########
@@ -84,6 +84,7 @@ The following tables lists the configurable parameters of the apisix-dashboard c
| Name | Description | Value |
| ----------------------------------------------- | ----------------------------------------------------------------------------------------- | --------------- |
| `replicaCount` | Number of Apache APISIX Dashboard nodes | `1` |
+| `priorityClassName` | Set the priorityClassName for pods | `""` |
Review Comment:
```suggestion
| `priorityClassName` | Set the [priorityClassName](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) for pods | `""` |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] fengxsong commented on pull request #369: feat support for configuring priority class name
Posted by GitBox <gi...@apache.org>.
fengxsong commented on PR #369:
URL: https://github.com/apache/apisix-helm-chart/pull/369#issuecomment-1274421619
> LGTM. Please also record it to the README.
done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #369: feat support for configuring priority class name
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #369:
URL: https://github.com/apache/apisix-helm-chart/pull/369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #369: feat support for configuring priority class name
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #369:
URL: https://github.com/apache/apisix-helm-chart/pull/369#discussion_r992908054
##########
charts/apisix-dashboard/README.md:
##########
@@ -84,7 +84,7 @@ The following tables lists the configurable parameters of the apisix-dashboard c
| Name | Description | Value |
| ----------------------------------------------- | ----------------------------------------------------------------------------------------- | --------------- |
| `replicaCount` | Number of Apache APISIX Dashboard nodes | `1` |
-| `priorityClassName` | Set the priorityClassName for pods | `""` |
+| `priorityClassName` | Set the [priorityClassName](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) for pods | `""` |
Review Comment:
All places you add this field should be changed, not only here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org