[GitHub] [wicket] solomax commented on a diff in pull request #545: Cleanup JUnit 5 assertions

[GitBox <gi...@apache.org>]

solomax commented on code in PR #545:
URL: https://github.com/apache/wicket/pull/545#discussion_r1001574012


##########
wicket-spring/src/test/java/org/apache/wicket/spring/FieldBeansCollectorTest.java:
##########
@@ -40,7 +40,7 @@ public void resolveGenericList() throws Exception
 
 		FieldBeansCollector fieldBeansCollector = new FieldBeansCollector(resolvableType);
 
-		assertTrue(fieldBeansCollector.getFieldType() == FieldType.LIST);
+		assertEquals(fieldBeansCollector.getFieldType(), FieldType.LIST);

Review Comment:
   arg positions also need to be be updated :)
   are there any tools to check such errors? :)
   
   `assertEquals(byte expected, byte actual, String message)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org