[jira] [Commented] (VALIDATOR-367) TLD list of DomainValidator is out of date (159 of 947 not available)

["Gary Gregory (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VALIDATOR-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566108#comment-14566108 ] 

Gary Gregory commented on VALIDATOR-367:
----------------------------------------

Welcome to Apache Commons!

Unless trivial, a patch is best accompanied by a unit test. Since I am not an SME in this component, I wonder if this update needs an update to unit tests.

You should also run a Maven build for to make sure the patch does not cause any regressions and say so. "If ran 'mvn test' and got no errors" or the same with 'mvn site' or 'mvn package' it depends on the patch. Running a full build with 'mvn site' usually does not take long and lets you check for FindBugs, PMD, Cllirr, RAT, and Checktyle issues in the site's reports section. Note that not all projects are set up with the same reports.

I won't apply this patch myself now but let someone who is closer to the component do so.

Thank you!

> TLD list of DomainValidator is out of date (159 of 947 not available)
> ---------------------------------------------------------------------
>
>                 Key: VALIDATOR-367
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-367
>             Project: Commons Validator
>          Issue Type: Bug
>          Components: Routines
>    Affects Versions: 1.4.1 Release
>            Reporter: Ayoma Gayan Wijethunga
>         Attachments: DomainValidator.java.patch
>
>
> TLD list of DomainValidator is out of date.
> 159 new TLDs out of 947 are not available in DomainValidator. 
> Until such time as a better method is implemented, adding new entries from  http://data.iana.org/TLD/tlds-alpha-by-domain.txt
> Main reason for creating this issue is that unavailability of relevant TLDs result in 16% failure in a local parameterised unit test, which tests against email addressed from all possible TLDs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)