You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2009/10/15 07:46:31 UTC

[jira] Created: (HIVE-880) user group information not populated for pre and post hook

user group information not populated for pre and post hook
----------------------------------------------------------

                 Key: HIVE-880
                 URL: https://issues.apache.org/jira/browse/HIVE-880
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Query Processor
            Reporter: Namit Jain
            Assignee: Namit Jain




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-880) user group information not populated for pre and post hook

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-880:
----------------------------

    Attachment: hive.880.4.patch

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch, hive.880.2.patch, hive.880.3.patch, hive.880.4.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-880) user group information not populated for pre and post hook

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766955#action_12766955 ] 

Zheng Shao commented on HIVE-880:
---------------------------------

Somehow the patch failed the unit tests.

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch, hive.880.2.patch, hive.880.3.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-880) user group information not populated for pre and post hook

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765927#action_12765927 ] 

Zheng Shao commented on HIVE-880:
---------------------------------

In the Hadoop world, ugi information is saved in conf.

I think Hive should call:

{code}
class UnixUserGroupInformation:
public static UnixUserGroupInformation login(Configuration conf, boolean save = true);
{code}

on session start.

User can modify "ugi" through "set" if they want.

And hooks will get ugi information from HiveConf.


If we want to keep the interface of hooks intact, we can get the ugi information from HiveConf by using UnixUserGroupInformation.UGI_PROPERTY_NAME.


> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-880) user group information not populated for pre and post hook

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766360#action_12766360 ] 

Zheng Shao commented on HIVE-880:
---------------------------------

I will change it to stringifyException(e) instead of e.getMessage(), otherwise it will be hard to know what happened.
Otherwise it looks OK. will test and commit.


> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch, hive.880.2.patch, hive.880.3.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-880) user group information not populated for pre and post hook

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-880:
----------------------------

    Status: Patch Available  (was: Open)

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-880) user group information not populated for pre and post hook

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766307#action_12766307 ] 

Prasad Chakka commented on HIVE-880:
------------------------------------

i think we do something similar in DDLTask (for getting the username for table owner).

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch, hive.880.2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-880) user group information not populated for pre and post hook

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765923#action_12765923 ] 

Namit Jain commented on HIVE-880:
---------------------------------

still running the tests

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-880) user group information not populated for pre and post hook

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-880:
----------------------------

    Attachment: hive.880.1.patch

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-880) user group information not populated for pre and post hook

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765939#action_12765939 ] 

Zheng Shao commented on HIVE-880:
---------------------------------

A better way would be:

when Hive session starts, we should call:
{code}
class UnixUserGroupInformation:
  public static UnixUserGroupInformation login(Configuration conf, boolean save=true);
{code}

to save the ugi to HiveConf.

Then users are free to change ugi using "set" command if they want.

Hooks will get ugi from HiveConf just as the main query.


If we want to keep the Hooks interface, we can get the ugi from hiveconf when we call the hooks.


> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-880) user group information not populated for pre and post hook

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-880:
----------------------------

    Attachment: hive.880.2.patch

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch, hive.880.2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-880) user group information not populated for pre and post hook

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-880:
----------------------------

       Resolution: Fixed
    Fix Version/s: 0.5.0
                   0.4.1
     Release Note: HIVE-880. User group information not populated for pre and post hook. (Namit Jain via zshao)
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed. Thanks Namit!

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.4.1, 0.5.0
>
>         Attachments: hive.880.1.patch, hive.880.2.patch, hive.880.3.patch, hive.880.4.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-880) user group information not populated for pre and post hook

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-880:
----------------------------

    Attachment: hive.880.3.patch

added log messages - will do DDLTask cleanup in a separate jira later

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch, hive.880.2.patch, hive.880.3.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-880) user group information not populated for pre and post hook

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766310#action_12766310 ] 

Zheng Shao commented on HIVE-880:
---------------------------------

hive.880.2.patch: nitpick: Can we do "log.WARN" in the places that we ignore the exceptions?
We can change DDLTask to use the same logic in the same transaction if you want.


> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: hive.880.1.patch, hive.880.2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-880) user group information not populated for pre and post hook

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-880:
----------------------------

    Fix Version/s:     (was: 0.4.1)

Actually this is only fixed in trunk - the patch does not work for branch-0.4.

> user group information not populated for pre and post hook
> ----------------------------------------------------------
>
>                 Key: HIVE-880
>                 URL: https://issues.apache.org/jira/browse/HIVE-880
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.5.0
>
>         Attachments: hive.880.1.patch, hive.880.2.patch, hive.880.3.patch, hive.880.4.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.