You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/05 07:13:03 UTC
[GitHub] [airflow] j-martin commented on pull request #28736: css, cap dropdown menu size dynamically
j-martin commented on PR #28736:
URL: https://github.com/apache/airflow/pull/28736#issuecomment-1371859134
In this case, the `85vh` is only ever reached if the menu items count is significant enough. Prior to https://github.com/apache/airflow/pull/28561, the menu could be much longer than the browser viewport (so `> 100vh`). With this in mind the change here is better than the current behavior.
If I interpret your suggestion properly we'd have something like `min(85vh, 500px)`. As a users, I would rather have `85vh` so I can see all the menu items if they fit in my viewport.
For context, we programmatically generate menu items to different projects (dag bags) and there can be a lot of them:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org