You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/09/21 15:32:07 UTC
Review Request 62467: Add UID/GID related issue with external users
not listed in /etc/passwd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
Bugs: AMBARI-22027
https://issues.apache.org/jira/browse/AMBARI-22027
Repository: ambari
Description
-------
Why this works?
If there is no custom uids it will use system-defined uid(behaivor before GID\UID feature) and will not try to use UID that occupied by external systems, like ldap.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py ee950e8
ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py a13ac24
Diff: https://reviews.apache.org/r/62467/diff/1/
Testing
-------
mvn clean test, cluster deployment.
Thanks,
Eugene Chekanskiy
Re: Review Request 62467: Add UID/GID related issue with external
users not listed in /etc/passwd
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/
-----------------------------------------------------------
(Updated Sept. 21, 2017, 6 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
Changes
-------
added doc, fixed bug
Bugs: AMBARI-22027
https://issues.apache.org/jira/browse/AMBARI-22027
Repository: ambari
Description
-------
Why this works?
If there is no custom uids it will use system-defined uid(behaivor before GID\UID feature) and will not try to use UID that occupied by external systems, like ldap.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py bcd4b17
ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py a13ac24
Diff: https://reviews.apache.org/r/62467/diff/2/
Changes: https://reviews.apache.org/r/62467/diff/1-2/
Testing
-------
mvn clean test, cluster deployment.
Thanks,
Eugene Chekanskiy
Re: Review Request 62467: Add UID/GID related issue with external
users not listed in /etc/passwd
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/#review185896
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Sept. 21, 2017, 11:32 a.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62467/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 11:32 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
>
>
> Bugs: AMBARI-22027
> https://issues.apache.org/jira/browse/AMBARI-22027
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Why this works?
> If there is no custom uids it will use system-defined uid(behaivor before GID\UID feature) and will not try to use UID that occupied by external systems, like ldap.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py ee950e8
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py a13ac24
>
>
> Diff: https://reviews.apache.org/r/62467/diff/1/
>
>
> Testing
> -------
>
> mvn clean test, cluster deployment.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 62467: Add UID/GID related issue with external
users not listed in /etc/passwd
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62467/#review185902
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py
Line 159 (original), 158 (patched)
<https://reviews.apache.org/r/62467/#comment262241>
how about adding comment with meaning of None?
- Dmitro Lisnichenko
On Sept. 21, 2017, 6:32 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62467/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 6:32 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
>
>
> Bugs: AMBARI-22027
> https://issues.apache.org/jira/browse/AMBARI-22027
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Why this works?
> If there is no custom uids it will use system-defined uid(behaivor before GID\UID feature) and will not try to use UID that occupied by external systems, like ldap.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/shared_initialization.py ee950e8
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py a13ac24
>
>
> Diff: https://reviews.apache.org/r/62467/diff/1/
>
>
> Testing
> -------
>
> mvn clean test, cluster deployment.
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>