You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tdas <gi...@git.apache.org> on 2016/06/17 08:36:19 UTC

[GitHub] spark issue #13727: [SPARK-15982][SPARK-16009][SPARK-16007][SQL] Harmonize t...

Github user tdas commented on the issue:

    https://github.com/apache/spark/pull/13727
  
    @gatorsmile I updated my tests to rigorously test this. However since this PR is about testing the common behavior (e.g. whether all of them respect user schema or not), I have not added tests for the case where there are no paths AND no user schema. The behavior will be source-specific - `parquet/json/csv` should throw error, whereas `text` should not. Could you make a PR that tests these in  CSVSuite, etc. if they are not already tested?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org