You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wido den Hollander <wi...@widodh.nl> on 2014/02/07 10:33:12 UTC
Re: Review Request 15932: Add support for Primary Storage on Gluster using
the libvirt backend
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15932/#review33922
-----------------------------------------------------------
My sincere apologies Niels! I completely missed the second version of your patch!
I just took a look at it again and it seems pretty straight forward. Most of the RBD code did a lot of work for you, so it's fairly easy to have GlusterFS in CS.
I tried applying the patch to the master branch and that failed. It seems that you wrote the patch against the 4.2 branch, correct?
Could you try to rebase it again master? If it then applies we might be able to get GlusterFS into 4.4! :)
- Wido den Hollander
On Jan. 14, 2014, 3:54 p.m., Niels de Vos wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15932/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 3:54 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The support for Gluster as Primary Storage is mostly based on the
> implementation for NFS. Like NFS, libvirt can address a Gluster environment
> through the 'netfs' pool-type.
>
>
> Diffs
> -----
>
> api/src/com/cloud/storage/Storage.java 07b6667
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 182cb22
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java e181cea
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolXMLParser.java a707a0b
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 6aaabc5
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java aaefc16
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java 0760e51
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 7555c1e
>
> Diff: https://reviews.apache.org/r/15932/diff/
>
>
> Testing
> -------
>
> See http://blog.nixpanic.net/2013/12/using-gluster-as-primary-storage-in.html
>
>
> Thanks,
>
> Niels de Vos
>
>
Re: Review Request 15932: Add support for Primary Storage on Gluster
using the libvirt backend
Posted by John Mark Walker <jo...@johnmark.org>.
Awesome. Thanks, guys!
On Feb 7, 2014 5:15 AM, "Niels de Vos" <nd...@redhat.com> wrote:
>
>
> > On Feb. 7, 2014, 10:33 a.m., Wido den Hollander wrote:
> > > My sincere apologies Niels! I completely missed the second version of
> your patch!
> > >
> > > I just took a look at it again and it seems pretty straight forward.
> Most of the RBD code did a lot of work for you, so it's fairly easy to have
> GlusterFS in CS.
> > >
> > > I tried applying the patch to the master branch and that failed. It
> seems that you wrote the patch against the 4.2 branch, correct?
> > >
> > > Could you try to rebase it again master? If it then applies we might
> be able to get GlusterFS into 4.4! :)
>
> Sure, no problem!
> I've done a rebase against 4.3 already, moving to master or 4.4 should not
> take too much time.
>
>
> - Niels
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15932/#review33922
> -----------------------------------------------------------
>
>
> On Jan. 14, 2014, 4:54 p.m., Niels de Vos wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/15932/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 14, 2014, 4:54 p.m.)
> >
> >
> > Review request for cloudstack.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > The support for Gluster as Primary Storage is mostly based on the
> > implementation for NFS. Like NFS, libvirt can address a Gluster
> environment
> > through the 'netfs' pool-type.
> >
> >
> > Diffs
> > -----
> >
> > api/src/com/cloud/storage/Storage.java 07b6667
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
> 182cb22
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java
> e181cea
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolXMLParser.java
> a707a0b
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
> 6aaabc5
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
> aaefc16
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
> 0760e51
> >
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
> 7555c1e
> >
> > Diff: https://reviews.apache.org/r/15932/diff/
> >
> >
> > Testing
> > -------
> >
> > See
> http://blog.nixpanic.net/2013/12/using-gluster-as-primary-storage-in.html
> >
> >
> > Thanks,
> >
> > Niels de Vos
> >
> >
>
>
Re: Review Request 15932: Add support for Primary Storage on Gluster using
the libvirt backend
Posted by Niels de Vos <nd...@redhat.com>.
> On Feb. 7, 2014, 10:33 a.m., Wido den Hollander wrote:
> > My sincere apologies Niels! I completely missed the second version of your patch!
> >
> > I just took a look at it again and it seems pretty straight forward. Most of the RBD code did a lot of work for you, so it's fairly easy to have GlusterFS in CS.
> >
> > I tried applying the patch to the master branch and that failed. It seems that you wrote the patch against the 4.2 branch, correct?
> >
> > Could you try to rebase it again master? If it then applies we might be able to get GlusterFS into 4.4! :)
Sure, no problem!
I've done a rebase against 4.3 already, moving to master or 4.4 should not take too much time.
- Niels
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15932/#review33922
-----------------------------------------------------------
On Jan. 14, 2014, 4:54 p.m., Niels de Vos wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15932/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 4:54 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The support for Gluster as Primary Storage is mostly based on the
> implementation for NFS. Like NFS, libvirt can address a Gluster environment
> through the 'netfs' pool-type.
>
>
> Diffs
> -----
>
> api/src/com/cloud/storage/Storage.java 07b6667
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 182cb22
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java e181cea
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolXMLParser.java a707a0b
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 6aaabc5
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java aaefc16
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java 0760e51
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 7555c1e
>
> Diff: https://reviews.apache.org/r/15932/diff/
>
>
> Testing
> -------
>
> See http://blog.nixpanic.net/2013/12/using-gluster-as-primary-storage-in.html
>
>
> Thanks,
>
> Niels de Vos
>
>