You are viewing a plain text version of this content. The canonical link for it is here.
Posted to kerby@directory.apache.org by "Zheng, Kai" <ka...@intel.com> on 2015/07/16 14:48:46 UTC
Move kerby-config and kerby-util modules out of lib to the top
Hi all,
The lib folder only contains two sub modules, kerby-config and kerby-util, which looks a little weird. I'm going to move them to the top, any concern? Thanks.
Regards,
Kai
RE: Move kerby-config and kerby-util modules out of lib to the top
Posted by "Zheng, Kai" <ka...@intel.com>.
Thanks for the confirm. I will get it done when make sure it won't mess pending commits.
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Thursday, July 16, 2015 11:33 PM
To: kerby@directory.apache.org
Subject: Re: Move kerby-config and kerby-util modules out of lib to the top
Le 16/07/15 17:04, Zheng, Kai a écrit :
>
>>> Why would you like to move kerby-config and kerby-util one level ? (btw, I think 'lib' is an atrocious name).
> Initially Kiran used to propose positioning the two modules as top level modules, but I was afraid the global top level modules are too many, which doesn't happen in fact. It looks more natural to see the two modules as top level not only because of their functions in future, but also because we hardly have a good container name better than 'lib'. Sound good?
Sounds good to me. I don't like 'lib', it does not convey any information about what's in, and config and utils deserves to be put at top level.
Re: Move kerby-config and kerby-util modules out of lib to the top
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 16/07/15 17:04, Zheng, Kai a écrit :
>
>>> Why would you like to move kerby-config and kerby-util one level ? (btw, I think 'lib' is an atrocious name).
> Initially Kiran used to propose positioning the two modules as top level modules, but I was afraid the global top level modules are too many, which doesn't happen in fact. It looks more natural to see the two modules as top level not only because of their functions in future, but also because we hardly have a good container name better than 'lib'. Sound good?
Sounds good to me. I don't like 'lib', it does not convey any
information about what's in, and config and utils deserves to be put at
top level.
RE: Move kerby-config and kerby-util modules out of lib to the top
Posted by "Zheng, Kai" <ka...@intel.com>.
Thanks Jiajia and Emmanuel for the thoughts.
>> Depends. It's fine for a module to contain only 2 sub-modules. If you look at kerby-tool, this is the same story.
Yes, the count doesn't justify the change. My bad.
>> Why would you like to move kerby-config and kerby-util one level ? (btw, I think 'lib' is an atrocious name).
Initially Kiran used to propose positioning the two modules as top level modules, but I was afraid the global top level modules are too many, which doesn't happen in fact. It looks more natural to see the two modules as top level not only because of their functions in future, but also because we hardly have a good container name better than 'lib'. Sound good?
Regards,
Kai
-----Original Message-----
From: Emmanuel Lécharny [mailto:elecharny@gmail.com]
Sent: Thursday, July 16, 2015 10:13 PM
To: kerby@directory.apache.org
Subject: Re: Move kerby-config and kerby-util modules out of lib to the top
Le 16/07/15 15:49, Li, Jiajia a écrit :
> I think it's fine.
>
> Thanks
> Jiajia
>
> -----Original Message-----
> From: Zheng, Kai [mailto:kai.zheng@intel.com]
> Sent: Thursday, July 16, 2015 8:49 PM
> To: kerby@directory.apache.org
> Subject: Move kerby-config and kerby-util modules out of lib to the
> top
>
> Hi all,
>
> The lib folder only contains two sub modules, kerby-config and kerby-util, which looks a little weird. I'm going to move them to the top, any concern? Thanks.
Depends. It's fine for a module to contain only 2 sub-modules. If you look at kerby-tool, this is the same story.
Why would you like to move kerby-config and kerby-util one level ? (btw, I think 'lib' is an atrocious name).
Re: Move kerby-config and kerby-util modules out of lib to the top
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 16/07/15 15:49, Li, Jiajia a écrit :
> I think it's fine.
>
> Thanks
> Jiajia
>
> -----Original Message-----
> From: Zheng, Kai [mailto:kai.zheng@intel.com]
> Sent: Thursday, July 16, 2015 8:49 PM
> To: kerby@directory.apache.org
> Subject: Move kerby-config and kerby-util modules out of lib to the top
>
> Hi all,
>
> The lib folder only contains two sub modules, kerby-config and kerby-util, which looks a little weird. I'm going to move them to the top, any concern? Thanks.
Depends. It's fine for a module to contain only 2 sub-modules. If you
look at kerby-tool, this is the same story.
Why would you like to move kerby-config and kerby-util one level ? (btw,
I think 'lib' is an atrocious name).
RE: Move kerby-config and kerby-util modules out of lib to the top
Posted by "Li, Jiajia" <ji...@intel.com>.
I think it's fine.
Thanks
Jiajia
-----Original Message-----
From: Zheng, Kai [mailto:kai.zheng@intel.com]
Sent: Thursday, July 16, 2015 8:49 PM
To: kerby@directory.apache.org
Subject: Move kerby-config and kerby-util modules out of lib to the top
Hi all,
The lib folder only contains two sub modules, kerby-config and kerby-util, which looks a little weird. I'm going to move them to the top, any concern? Thanks.
Regards,
Kai