You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bruno Borges (JIRA)" <ji...@apache.org> on 2007/03/09 21:37:09 UTC

[jira] Created: (WICKET-374) Allow disable "autoEnable" for wicket:links

Allow disable "autoEnable" for wicket:links
-------------------------------------------

                 Key: WICKET-374
                 URL: https://issues.apache.org/jira/browse/WICKET-374
             Project: Wicket
          Issue Type: New Feature
          Components: wicket
    Affects Versions: 1.2.5
            Reporter: Bruno Borges
            Priority: Minor
             Fix For: 1.2.6


When using <wicket:link> to let Wicket lookup for pages and create the related links, it's not possible to change the "setAutoEnable" property, which defaults to true in wicket.markup.resolver.AutoLinkResolver.AutolinkBookmarkablePageLink class. This affects the prototype because, sometimes designers _want_ links to be enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-374) Allow disable "autoEnable" for wicket:links

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius reassigned WICKET-374:
--------------------------------------

    Assignee: Juergen Donnerstag  (was: Eelco Hillenius)

Juergen, if you have time, could you please take a look and see if you agree?

> Allow disable "autoEnable" for wicket:links
> -------------------------------------------
>
>                 Key: WICKET-374
>                 URL: https://issues.apache.org/jira/browse/WICKET-374
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Bruno Borges
>         Assigned To: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: WICKET-374.diff
>
>
> When using <wicket:link> to let Wicket lookup for pages and create the related links, it's not possible to change the "setAutoEnable" property, which defaults to true in wicket.markup.resolver.AutoLinkResolver.AutolinkBookmarkablePageLink class. This affects the prototype because, sometimes designers _want_ links to be enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-374) Allow disable "autoEnable" for wicket:links

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius reassigned WICKET-374:
--------------------------------------

    Assignee: Juergen Donnerstag  (was: Juergen Donnerstag)

other Juergen :)

> Allow disable "autoEnable" for wicket:links
> -------------------------------------------
>
>                 Key: WICKET-374
>                 URL: https://issues.apache.org/jira/browse/WICKET-374
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Bruno Borges
>         Assigned To: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: WICKET-374.diff
>
>
> When using <wicket:link> to let Wicket lookup for pages and create the related links, it's not possible to change the "setAutoEnable" property, which defaults to true in wicket.markup.resolver.AutoLinkResolver.AutolinkBookmarkablePageLink class. This affects the prototype because, sometimes designers _want_ links to be enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-374) Allow disable "autoEnable" for wicket:links

Posted by "Bruno Borges (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Borges updated WICKET-374:
--------------------------------

    Attachment: WICKET-374.diff

This is the patch implementing this issue. It allows for global and "per page" configuration.

Per page:
   <wicket:link keepautolink="true">

Global:
   getMarkupSettings().setKeepAutomaticLinks(true);

It's not possible to do this configuration through Java code in WebPages/Panels, etc... Because it uses BookmarkableLink and so, there's no Page instance available.

Regards,
Bruno Borges

> Allow disable "autoEnable" for wicket:links
> -------------------------------------------
>
>                 Key: WICKET-374
>                 URL: https://issues.apache.org/jira/browse/WICKET-374
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Bruno Borges
>            Priority: Minor
>             Fix For: 1.2.6
>
>         Attachments: WICKET-374.diff
>
>
> When using <wicket:link> to let Wicket lookup for pages and create the related links, it's not possible to change the "setAutoEnable" property, which defaults to true in wicket.markup.resolver.AutoLinkResolver.AutolinkBookmarkablePageLink class. This affects the prototype because, sometimes designers _want_ links to be enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-374) Allow disable "autoEnable" for wicket:links

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-374.
---------------------------------------

    Resolution: Fixed

I've implemented a realy simple solution, since this feature has not yet been requests many times. In order change the default simply set 
AutolinkBookmarkablePageLink.autoEnable=false/true.
This a global setting, a per page setting has not yet been implemented.
Please re-open this issue, if you think the solution is not sufficient.

> Allow disable "autoEnable" for wicket:links
> -------------------------------------------
>
>                 Key: WICKET-374
>                 URL: https://issues.apache.org/jira/browse/WICKET-374
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Bruno Borges
>         Assigned To: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: WICKET-374.diff
>
>
> When using <wicket:link> to let Wicket lookup for pages and create the related links, it's not possible to change the "setAutoEnable" property, which defaults to true in wicket.markup.resolver.AutoLinkResolver.AutolinkBookmarkablePageLink class. This affects the prototype because, sometimes designers _want_ links to be enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-374) Allow disable "autoEnable" for wicket:links

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius reassigned WICKET-374:
--------------------------------------

    Assignee: Eelco Hillenius

> Allow disable "autoEnable" for wicket:links
> -------------------------------------------
>
>                 Key: WICKET-374
>                 URL: https://issues.apache.org/jira/browse/WICKET-374
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Bruno Borges
>         Assigned To: Eelco Hillenius
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: WICKET-374.diff
>
>
> When using <wicket:link> to let Wicket lookup for pages and create the related links, it's not possible to change the "setAutoEnable" property, which defaults to true in wicket.markup.resolver.AutoLinkResolver.AutolinkBookmarkablePageLink class. This affects the prototype because, sometimes designers _want_ links to be enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-374) Allow disable "autoEnable" for wicket:links

Posted by "Eelco Hillenius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eelco Hillenius updated WICKET-374:
-----------------------------------

        Fix Version/s:     (was: 1.2.6)
                       1.3
    Affects Version/s:     (was: 1.2.5)
                       1.3

> Allow disable "autoEnable" for wicket:links
> -------------------------------------------
>
>                 Key: WICKET-374
>                 URL: https://issues.apache.org/jira/browse/WICKET-374
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Bruno Borges
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: WICKET-374.diff
>
>
> When using <wicket:link> to let Wicket lookup for pages and create the related links, it's not possible to change the "setAutoEnable" property, which defaults to true in wicket.markup.resolver.AutoLinkResolver.AutolinkBookmarkablePageLink class. This affects the prototype because, sometimes designers _want_ links to be enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.