[jira] [Work logged] (KNOX-2289) Query string encryption password never created due to GatewayServices is being null

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-2289?focusedWorklogId=401779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401779 ]

ASF GitHub Bot logged work on KNOX-2289:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Mar/20 20:55
            Start Date: 11/Mar/20 20:55
    Worklog Time Spent: 10m 
      Work Description: smolnar82 commented on pull request #288: KNOX-2289 - Passing GatewayServer.getGatewayServices() to SimpleDescriptorHandler.handle() as it needs it to provision encryption query string password
URL: https://github.com/apache/knox/pull/288
 
 
   ## What changes were proposed in this pull request?
   
   (Please fill in changes proposed in this fix)
   
   ## How was this patch tested?
   
   Manually tested:
   
   - redeployed Knox with my changes
   - had a CM descriptor with two topologies: `topology1` and `topology2`
   - started Knox: the CM descriptor got picked up and generated into toplogies
   - confirmed that:
     - the previous ERROR message - `Failed to create a password for query string encryption for` - did not show up in the log
     - the password was created
   
   ```
   $ bin/knoxcli.sh list-alias --cluster topology2
   Listing aliases for: topology2
   encryptquerystring
   
   1 items.
   
   $ bin/knoxcli.sh list-alias --cluster topology1
   Listing aliases for: topology1
   encryptquerystring
   
   1 items.
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 401779)
    Remaining Estimate: 0h
            Time Spent: 10m

> Query string encryption password never created due to GatewayServices is being null
> -----------------------------------------------------------------------------------
>
>                 Key: KNOX-2289
>                 URL: https://issues.apache.org/jira/browse/KNOX-2289
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 1.4.0
>            Reporter: Sandor Molnar
>            Assignee: Sandor Molnar
>            Priority: Major
>             Fix For: 1.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> During the work of KNOX-2178, the {{SImpleDescriptorHandler}} class was moved to a new Maven module and - to break a circular dependency - we stopped using {{GatewayServer.getGatewayServices}}. However, I failed to add this call into the client which invokes {{SImpleDescriptorHandler.handle(...)}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)